Skip to content

Abort vizio zeroconf config flow if unique ID is already configured#34313

Merged
balloob merged 3 commits intohome-assistant:devfrom
raman325:vizio_bugfix
Apr 16, 2020
Merged

Abort vizio zeroconf config flow if unique ID is already configured#34313
balloob merged 3 commits intohome-assistant:devfrom
raman325:vizio_bugfix

Conversation

@raman325
Copy link
Copy Markdown
Contributor

Proposed change

@balloob pointed out in #34280 that I should be aborting discovery config flows when a device has been previously ignored. This change should do that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@balloob balloob merged commit c9cc024 into home-assistant:dev Apr 16, 2020
@raman325 raman325 deleted the vizio_bugfix branch April 16, 2020 23:17
@balloob balloob mentioned this pull request Apr 17, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 19, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants