Add new optional parameter for ConfigEntries.async_entries to specify whether or not ignored entries should be included#34298
Closed
raman325 wants to merge 3 commits intohome-assistant:devfrom
Closed
Conversation
…whether or not ignored entries should be included
Member
|
I don't think that it's a good idea. We shouldn't ignore ignored entries in our checks if things are already set up . |
Contributor
Author
|
It's useful for my case where I am iterating through config entries to check for the existence of keys that wouldn't exist on an ignored entry, but I can close this if you don't think this is a problem for other integration |
Member
|
Let's not add it to the main object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
In fixing an issue with the
viziointegration I thought it would be nice if theasync_entriesfunction could return only non-ignored config entries so that other integrations do not have to build custom logic likeviziohas. This change adds an optional additional parameter to the function that will optionally filter ignored config entries out. The default is set to make this change backwards compatible.Type of change
Additional information
Checklist
black --fast homeassistant tests)The integration reached or maintains the following Integration Quality Scale: