Skip to content

Use mock storage for MQTT tests#33553

Merged
bdraco merged 2 commits intohome-assistant:devfrom
dmulcahey:dm/mock-mqtt-storage
Apr 2, 2020
Merged

Use mock storage for MQTT tests#33553
bdraco merged 2 commits intohome-assistant:devfrom
dmulcahey:dm/mock-mqtt-storage

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

Proposed change

This PR makes a few tests using TestCase use mock storage.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@dmulcahey dmulcahey requested a review from balloob April 2, 2020 21:10
@probot-home-assistant probot-home-assistant Bot added core has-tests small-pr PRs with less than 30 lines. labels Apr 2, 2020
@dmulcahey dmulcahey changed the title Use mock storage for MQTT Use mock storage for MQTT tests Apr 2, 2020
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 2, 2020

Same fix as #33456

@bdraco bdraco self-requested a review April 2, 2020 22:13
@bdraco bdraco merged commit 201e958 into home-assistant:dev Apr 2, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
@dmulcahey dmulcahey deleted the dm/mock-mqtt-storage branch April 4, 2020 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants