Skip to content

Fix uncaught exceptions for tradfri#33550

Merged
springstan merged 1 commit intohome-assistant:devfrom
ziv1234:fix4
Apr 2, 2020
Merged

Fix uncaught exceptions for tradfri#33550
springstan merged 1 commit intohome-assistant:devfrom
ziv1234:fix4

Conversation

@ziv1234
Copy link
Copy Markdown
Contributor

@ziv1234 ziv1234 commented Apr 2, 2020

was caused by device_info being mocks, so write to storage failed

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

was caused by device_info being mocks, so write to storage failed
@probot-home-assistant probot-home-assistant Bot added core has-tests small-pr PRs with less than 30 lines. labels Apr 2, 2020
@MartinHjelmare MartinHjelmare changed the title fixed uncaught exceptions for tradfri Fix uncaught exceptions for tradfri Apr 2, 2020
@springstan
Copy link
Copy Markdown
Member

CI checks have been fixed by #33553

@springstan springstan merged commit f2dad79 into home-assistant:dev Apr 2, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix tradfri tests that have uncaught exceptions

4 participants