Don't write storage to disk while stopping#33456
Merged
balloob merged 12 commits intohome-assistant:devfrom Apr 2, 2020
Merged
Don't write storage to disk while stopping#33456balloob merged 12 commits intohome-assistant:devfrom
balloob merged 12 commits intohome-assistant:devfrom
Conversation
Contributor
Author
|
I’ll look at the failure some more in the morning. I think there just needs to be a guard in the write data method... |
dmulcahey
commented
Mar 31, 2020
8627ca8 to
cfb0754
Compare
balloob
reviewed
Mar 31, 2020
balloob
reviewed
Mar 31, 2020
balloob
reviewed
Mar 31, 2020
ac56ca7 to
1498290
Compare
balloob
reviewed
Mar 31, 2020
balloob
approved these changes
Mar 31, 2020
5f8300e to
e3eb823
Compare
8752733 to
498d8cb
Compare
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR is a follow up to #33358 specifically this comment: #33358 (comment). The PR prevents storage from being written to disk while the HA state is
CoreState.stopping. The changes account for 3 scenarios:In all of these scenarios the data is held in memory and written when HA is in the final_write state.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: