Skip to content

Add new devices to HomematicIP Cloud#31914

Merged
springstan merged 2 commits into
home-assistant:devfrom
SukramJ:HmIP-AddDevices
Feb 19, 2020
Merged

Add new devices to HomematicIP Cloud#31914
springstan merged 2 commits into
home-assistant:devfrom
SukramJ:HmIP-AddDevices

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Feb 17, 2020

Proposed change

Adds:

  • HMIP-WTH-B (Wall Thermostat Basic)
  • ALPHA-IP-RBG (Alpha IP Wall Thermostat Display)
  • ALPHA-IP-RBGa (ALpha IP Wall Thermostat Display analog)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Adds:
- HMIP-WTH-B (Wall Thermostat Basic)
- ALPHA-IP-RBG (Alpha IP Wall Thermostat Display)
- ALPHA-IP-RBGa (ALpha IP Wall Thermostat Display analog)
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2020

Codecov Report

Merging #31914 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31914      +/-   ##
==========================================
- Coverage   94.69%   94.68%   -0.01%     
==========================================
  Files         763      763              
  Lines       55183    55186       +3     
==========================================
  Hits        52255    52255              
- Misses       2928     2931       +3
Impacted Files Coverage Δ
...meassistant/components/homematicip_cloud/sensor.py 100% <100%> (ø) ⬆️
homeassistant/components/template/cover.py 96.34% <0%> (-1.37%) ⬇️
homeassistant/bootstrap.py 72.78% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2366b5f...6389952. Read the comment docs.

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✌ just one small comment, could you please take a look?

Comment thread homeassistant/components/homematicip_cloud/sensor.py Outdated
Co-Authored-By: springstan <46536646+springstan@users.noreply.github.com>
@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Feb 19, 2020

Hi @springstan, any chance to get this PR and #31916 get merged today?
Thanks a lot.

@springstan
Copy link
Copy Markdown
Member

Sure thing @SukramJ! No problem at all :)

@springstan springstan merged commit f4f01cb into home-assistant:dev Feb 19, 2020
@SukramJ SukramJ deleted the HmIP-AddDevices branch February 19, 2020 10:00
@SukramJ SukramJ mentioned this pull request Feb 19, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants