Skip to content

Fix test for HMIPC#31981

Merged
springstan merged 1 commit into
home-assistant:devfrom
SukramJ:patch-1
Feb 19, 2020
Merged

Fix test for HMIPC#31981
springstan merged 1 commit into
home-assistant:devfrom
SukramJ:patch-1

Conversation

@SukramJ
Copy link
Copy Markdown
Contributor

@SukramJ SukramJ commented Feb 19, 2020

Proposed change

This fixes a test failure caused by two parallel HMIPC PRs (#31914, #31916).
My fault.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added has-tests small-pr PRs with less than 30 lines. labels Feb 19, 2020
@SukramJ SukramJ requested a review from springstan February 19, 2020 11:01
@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Feb 19, 2020

Please have a look at this PR. This fixes a failing test in dev branch, that was caused by my parallel PR before.

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when the CI tests pass ✌

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2020

Codecov Report

Merging #31981 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31981   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files         766      766           
  Lines       55569    55578    +9     
=======================================
+ Hits        52619    52628    +9     
  Misses       2950     2950           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d87490...7436f6c. Read the comment docs.

@springstan springstan merged commit da4c08d into home-assistant:dev Feb 19, 2020
@SukramJ SukramJ deleted the patch-1 branch February 19, 2020 11:42
@SukramJ
Copy link
Copy Markdown
Contributor Author

SukramJ commented Feb 19, 2020

Thanks a lot @springstan

@springstan
Copy link
Copy Markdown
Member

Of course @SukramJ

@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 19, 2020

This PR just unblocked the beta release! Thanks @SukramJ for fixing that so quickly 👍

@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants