Fix test for HMIPC#31981
Merged
Merged
Conversation
Contributor
Author
|
Please have a look at this PR. This fixes a failing test in dev branch, that was caused by my parallel PR before. |
springstan
approved these changes
Feb 19, 2020
Member
springstan
left a comment
There was a problem hiding this comment.
Can be merged when the CI tests pass ✌
Codecov Report
@@ Coverage Diff @@
## dev #31981 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 766 766
Lines 55569 55578 +9
=======================================
+ Hits 52619 52628 +9
Misses 2950 2950 Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks a lot @springstan |
Member
|
Of course @SukramJ ✌ |
Member
|
This PR just unblocked the beta release! Thanks @SukramJ for fixing that so quickly 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes a test failure caused by two parallel HMIPC PRs (#31914, #31916).
My fault.
Type of change
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: