Skip to content

Update emulated_roku to 0.1.9#30791

Merged
springstan merged 2 commits into
home-assistant:devfrom
jdeluyck:fix_emulatedroku
Jan 15, 2020
Merged

Update emulated_roku to 0.1.9#30791
springstan merged 2 commits into
home-assistant:devfrom
jdeluyck:fix_emulatedroku

Conversation

@jdeluyck
Copy link
Copy Markdown
Contributor

@jdeluyck jdeluyck commented Jan 15, 2020

Description:

Updates emulated_roku to 0.1.9, which gets rid of the reuse_address=True is no longer supported error.

Related to #30779

Checklist:

The code change is tested and works locally.

  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @jdeluyck,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant Bot added integration: emulated_roku small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade labels Jan 15, 2020
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was quick 😄

@jdeluyck
Copy link
Copy Markdown
Contributor Author

Well that was quick smile

No sense in letting this wait forever - upstream reacted very quickly, so.. :)

@springstan
Copy link
Copy Markdown
Member

Have you already tested it locally?

@jdeluyck
Copy link
Copy Markdown
Contributor Author

Yep. Copied my automation over from my running HA, and tested with my Harmony remote (which is where i'm using it).

I saw no change in usage - the old version still seems to work (atleast for me), but the errors are dirty.

@springstan
Copy link
Copy Markdown
Member

That is great to hear. Completely agree with your statement on the constant error messages, that can be really frustrating sometimes.

@springstan springstan merged commit 41469ce into home-assistant:dev Jan 15, 2020
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 15, 2020
* upstream/dev: (82 commits)
  Add support for vacuums to Alexa. (home-assistant#30764)
  Refactor Ring data handling (home-assistant#30777)
  Restore unit_of_measurement from entity registry (home-assistant#30780)
  Update pyubee to 0.8 (home-assistant#30785)
  Update emulated_roku to 0.1.9 (home-assistant#30791)
  Add Config Flow support, Device Registry support, available property to vizio component (home-assistant#30653)
  Allow input_* and timer component setup without config (home-assistant#30772)
  Search: Add search to default config and don't resolve area (home-assistant#30762)
  [ci skip] Translation update
  Use storage based collections for Timer platform (home-assistant#30765)
  Upgrade youtube_dl to version 2020.01.15 (home-assistant#30767)
  Whitelist Frenck for release
  Hass.io allow to reset password with CLI (home-assistant#30755)
  Revert home-assistant#29701 (home-assistant#30766)
  Add Safe Mode (home-assistant#30723)
  Update Ring to 0.6.0 (home-assistant#30748)
  Add support for the voltage sensor on the greeneye GEM (home-assistant#30484)
  Fix supported_features in MQTT fan (home-assistant#28680)
  Fix small typo in alarmdotcom component (home-assistant#30758)
  bump aiokef to 0.2.5 which uses locks (home-assistant#30753)
  ...
@frenck frenck added this to the 0.104.1 milestone Jan 16, 2020
balloob pushed a commit that referenced this pull request Jan 16, 2020
* Update emulated_roku to 0.1.9

* Update requirements_all
@balloob balloob mentioned this pull request Jan 16, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: emulated_roku small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants