Skip to content

Add support for vacuums to Alexa#30764

Merged
balloob merged 1 commit into
home-assistant:devfrom
ochlocracy:alexa-support-vacuum
Jan 15, 2020
Merged

Add support for vacuums to Alexa#30764
balloob merged 1 commit into
home-assistant:devfrom
ochlocracy:alexa-support-vacuum

Conversation

@ochlocracy
Copy link
Copy Markdown
Member

@ochlocracy ochlocracy commented Jan 14, 2020

Description:

This PR really sucks. 😁

Adds basic vacuum support to Alexa. Yields a PowerController, TimeHoldController, and RangeController for the fan speed depending on the vacuum supported features.

Utterances

Alexa, turn on vacuum
Alexa, turn off vacuum
Alexa, set vacuum fan speed to high
Alexa, set vacuum fan speed to 3
Alexa, pause the vacuum
Alexa, restart the vacuum

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!

@ochlocracy ochlocracy marked this pull request as ready for review January 14, 2020 21:03
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow looks good 🎉

@balloob balloob merged commit bb42ff9 into home-assistant:dev Jan 15, 2020
raman325 added a commit to raman325/home-assistant that referenced this pull request Jan 15, 2020
* upstream/dev: (82 commits)
  Add support for vacuums to Alexa. (home-assistant#30764)
  Refactor Ring data handling (home-assistant#30777)
  Restore unit_of_measurement from entity registry (home-assistant#30780)
  Update pyubee to 0.8 (home-assistant#30785)
  Update emulated_roku to 0.1.9 (home-assistant#30791)
  Add Config Flow support, Device Registry support, available property to vizio component (home-assistant#30653)
  Allow input_* and timer component setup without config (home-assistant#30772)
  Search: Add search to default config and don't resolve area (home-assistant#30762)
  [ci skip] Translation update
  Use storage based collections for Timer platform (home-assistant#30765)
  Upgrade youtube_dl to version 2020.01.15 (home-assistant#30767)
  Whitelist Frenck for release
  Hass.io allow to reset password with CLI (home-assistant#30755)
  Revert home-assistant#29701 (home-assistant#30766)
  Add Safe Mode (home-assistant#30723)
  Update Ring to 0.6.0 (home-assistant#30748)
  Add support for the voltage sensor on the greeneye GEM (home-assistant#30484)
  Fix supported_features in MQTT fan (home-assistant#28680)
  Fix small typo in alarmdotcom component (home-assistant#30758)
  bump aiokef to 0.2.5 which uses locks (home-assistant#30753)
  ...
@lock lock Bot locked and limited conversation to collaborators Jan 16, 2020
@ochlocracy ochlocracy deleted the alexa-support-vacuum branch January 23, 2020 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants