Venetian blind support for proprietary Fibaro FGRM-222 Roller Shutter devices#29701
Merged
Conversation
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration ( |
Contributor
|
Thank you for following up on this! |
The Fibaro FGR-222/FGRM-2222 ZWave roller shutter devices have a proprietary command class to support setting the tilt angle of venetian blinds (= type of window cover). This PR adds the support to HA for this. This allows the user to set the height of the blinds and the tilt angle separately. Original patch by @ChristianKuehnel #24405.
Contributor
Author
|
Rebased due to conflict introduced by 16a7408 @MartinHjelmare do you feel like reviewing this? :) |
Member
|
Someone from the zwave team should review first. |
Contributor
Author
|
CC @cgarwood who was involved in review in the original PR as well. Can you take a look, or know someone who is responsible? |
cgarwood
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt at @ChristianKuehnel's original patch from closed and unmerged PR #24405.
I attributed you in the commit message, hope that's okay!
The needed open-zwave dependency has landed in the meantime (home-assistant/open-zwave#6), so we can give it another try.
I changed the heuristic for detecting a device with tilt support slightly. In Christian's original patch, we needed to observe a tilt-angle > 0 to turn tilt-support on. From personal experience I found this to be very impracticable, because chances are high that when you need to restart home-assistant, one of your covers has the blinds down and therefore reports angle 0.
I removed the angle check. Reasoning is commented inline in the code.
The patch has been tested with my Fibaro devices (I've been running it locally for half a year now).
CC @MartinHjelmare
Breaking Change:
Should not break anything.
Description:
The Fibaro FGR-222/FGRM-2222 ZWave roller shutter devices have a proprietary
command class to support setting the tilt angle of venetian blinds (= type of
window cover). This PR adds the support to HA for this. This allows the user to
set the height of the blinds and the tilt angle separately.
Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: