Skip to content

Remove suppress_warning from config options for vizio component#30536

Merged
balloob merged 8 commits into
home-assistant:devfrom
raman325:vizio_suppress_warning
Jan 7, 2020
Merged

Remove suppress_warning from config options for vizio component#30536
balloob merged 8 commits into
home-assistant:devfrom
raman325:vizio_suppress_warning

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Jan 7, 2020

Breaking Change:

Removed suppress_warning as a config option for the vizio component.

Description:

The pyvizio component now suppresses insecure HTTPS request warnings in a way that doesn't affect global requests from other components, HA, etc. There is no need to globally suppress insecure warnings now.

NOTE: Should follow merge of #30522 since it incorporates those changes

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11650

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: vizio
    host: '<IP>:<PORT>'
    access_token: '<AUTH_TOKEN>'
    device_class: tv

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@raman325 raman325 force-pushed the vizio_suppress_warning branch from 470d085 to 26fcb79 Compare January 7, 2020 01:42
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit a9f6dd6 into home-assistant:dev Jan 7, 2020
@raman325 raman325 deleted the vizio_suppress_warning branch January 7, 2020 14:58
@lock lock Bot locked and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants