Update vizio component to prepare for config flow and zeroconf support#30522
Merged
Conversation
…et ESN if device setup is validated
MartinHjelmare
requested changes
Jan 6, 2020
Contributor
Author
|
I think the tests need to be re-ran if the failure is a concern |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
No functional changes
I am planning to add config flow support and zeroconf support for the
viziocomponent. In order to prepare for this, and to make the future PR simpler to review, I upgraded to the latest version ofpyvizio, moved constants toconst.py, and moved things related to schema validation to__init__.py. While I was in there, I added support for theiconproperty and changed the function call that the component uses to validate that the component is properly configured.Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.