Skip to content

Update vizio component to prepare for config flow and zeroconf support#30522

Merged
cgarwood merged 11 commits into
home-assistant:devfrom
raman325:vizio_zeroconf
Jan 7, 2020
Merged

Update vizio component to prepare for config flow and zeroconf support#30522
cgarwood merged 11 commits into
home-assistant:devfrom
raman325:vizio_zeroconf

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Jan 6, 2020

Description:

No functional changes

I am planning to add config flow support and zeroconf support for the vizio component. In order to prepare for this, and to make the future PR simpler to review, I upgraded to the latest version of pyvizio, moved constants to const.py, and moved things related to schema validation to __init__.py. While I was in there, I added support for the icon property and changed the function call that the component uses to validate that the component is properly configured.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@raman325 raman325 changed the title Refactor vizio component to prepare for config flow and zeroconf support Update vizio component to prepare for config flow and zeroconf support Jan 6, 2020
Comment thread homeassistant/components/vizio/__init__.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raman325
Copy link
Copy Markdown
Contributor Author

raman325 commented Jan 6, 2020

I think the tests need to be re-ran if the failure is a concern

@cgarwood cgarwood merged commit 7d58de1 into home-assistant:dev Jan 7, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants