Skip to content

Remove suppress_warning from config options for vizio component #30536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 8 commits into from
Jan 7, 2020
Merged

Remove suppress_warning from config options for vizio component #30536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b34f1c0
move constants, move schema validation to init, prepare for zeroconf/…
raman325 Jan 6, 2020
08a1c2e
mistake in refactor
raman325 Jan 6, 2020
5b73806
update .coveragerc, move validate_auth to __init__, only attempt to g…
raman325 Jan 6, 2020
066f858
fix schema validation
raman325 Jan 6, 2020
3e30db4
remove suppress warning config option
raman325 Jan 7, 2020
5eea6b3
remove config_flow from manifest since its not ready yet
raman325 Jan 7, 2020
26fcb79
update requirements_all.txt
raman325 Jan 7, 2020
141986c
fix issue with merge conflict
raman325 Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions homeassistant/components/vizio/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from homeassistant.helpers import config_validation as cv

from .const import (
CONF_SUPPRESS_WARNING,
CONF_VOLUME_STEP,
DEFAULT_DEVICE_CLASS,
DEFAULT_NAME,
Expand All @@ -33,7 +32,6 @@ def validate_auth(config):
vol.Required(CONF_HOST): cv.string,
vol.Optional(CONF_ACCESS_TOKEN): cv.string,
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Optional(CONF_SUPPRESS_WARNING, default=False): cv.boolean,
vol.Optional(CONF_DEVICE_CLASS, default=DEFAULT_DEVICE_CLASS): vol.All(
cv.string, vol.Lower, vol.In(["tv", "soundbar"])
),
Expand Down
1 change: 0 additions & 1 deletion homeassistant/components/vizio/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Constants used by vizio component."""

CONF_SUPPRESS_WARNING = "suppress_warning"
CONF_VOLUME_STEP = "volume_step"

DEFAULT_NAME = "Vizio SmartCast"
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/vizio/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Vizio",
"documentation": "https://www.home-assistant.io/integrations/vizio",
"requirements": [
"pyvizio==0.0.11"
"pyvizio==0.0.12"
],
"dependencies": [],
"codeowners": ["@raman325"]
Expand Down
15 changes: 1 addition & 14 deletions homeassistant/components/vizio/media_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import logging

from pyvizio import Vizio
from requests.packages import urllib3
import voluptuous as vol

from homeassistant import util
Expand All @@ -28,13 +27,7 @@
)

from . import VIZIO_SCHEMA, validate_auth
from .const import (
CONF_SUPPRESS_WARNING,
CONF_VOLUME_STEP,
DEFAULT_NAME,
DEVICE_ID,
ICON,
)
from .const import CONF_VOLUME_STEP, DEFAULT_NAME, DEVICE_ID, ICON

_LOGGER = logging.getLogger(__name__)

Expand Down Expand Up @@ -78,12 +71,6 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
)
return

if config[CONF_SUPPRESS_WARNING]:
_LOGGER.warning(
"InsecureRequestWarning is disabled "
"because of Vizio platform configuration"
)
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
add_entities([device], True)


Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1696,7 +1696,7 @@ pyversasense==0.0.6
pyvesync==1.1.0

# homeassistant.components.vizio
pyvizio==0.0.11
pyvizio==0.0.12

# homeassistant.components.velux
pyvlx==0.2.12
Expand Down