Skip to content

Refactor Freebox : add config flow + temperature sensor + signal dispatch#30334

Merged
bramkragten merged 45 commits into
home-assistant:devfrom
Quentame:freebox/config-flow
Mar 11, 2020
Merged

Refactor Freebox : add config flow + temperature sensor + signal dispatch#30334
bramkragten merged 45 commits into
home-assistant:devfrom
Quentame:freebox/config-flow

Conversation

@Quentame
Copy link
Copy Markdown
Member

@Quentame Quentame commented Dec 31, 2019 •
edited
Loading

Breaking Change:

None in the code.

But need to re-authorize HA to access the Freebox router.

Description:

Adding config flow to Freebox + temperature sensors

Can de done after :

  • add more sensors and services
  • refactor discovery
  • available entity state
  • API local polling

Pull request with documentation for home-assistant.io : home-assistant/home-assistant.io#11712
Pull request with frontend for home-assistant-polymer : home-assistant/frontend#4448

PS : HAPPY NEW YEAR 🎉 🎆 !

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link
Copy Markdown

probot-home-assistant Bot commented Dec 31, 2019

Hey there @SNoof85, mind taking a look at this pull request as its been labeled with a integration (freebox) you are listed as a codeowner for? Thanks!

@Quentame Quentame changed the title Add config flow to Freebox WIP : Add config flow to Freebox Dec 31, 2019
@SNoof85
Copy link
Copy Markdown
Contributor

SNoof85 commented Jan 1, 2020 •
edited
Loading

That is very nice @Quentame I started something in that way too but you were faster.
Like it !
You may add yourself as codeowner if you want. And a happy new year.

SNoof85
SNoof85 reviewed Jan 1, 2020
View reviewed changes
Comment thread homeassistant/components/freebox/const.py Outdated
@SNoof85
Copy link
Copy Markdown
Contributor

SNoof85 commented Jan 2, 2020

Tried it yesterday. Works fine.
I was thinking that adding a step after the form Host/Port to mention that the user has to press the right arrow on the Freebox router to validate the application access would be nice.

@Quentame Quentame force-pushed the freebox/config-flow branch 3 times, most recently from 9a641cc to 4f5cbdc Compare January 8, 2020 12:57
Quentame
Quentame commented Jan 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member Author

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to be done before remove the draft status + update the description

Comment thread homeassistant/components/freebox/device_tracker.py Outdated
Comment thread homeassistant/components/freebox/config_flow.py Outdated
Comment thread homeassistant/components/freebox/__init__.py Outdated
Comment thread homeassistant/components/freebox/__init__.py Outdated
Comment thread homeassistant/components/freebox/__init__.py Outdated
@Quentame Quentame self-assigned this Jan 9, 2020
@Quentame Quentame force-pushed the freebox/config-flow branch 2 times, most recently from 9ebdaa6 to e6c52e1 Compare January 10, 2020 12:37
@Quentame Quentame mentioned this pull request Jan 10, 2020
Merged
@Quentame Quentame force-pushed the freebox/config-flow branch 2 times, most recently from 737e13d to 13b81a3 Compare January 11, 2020 16:58
@Quentame Quentame marked this pull request as ready for review January 11, 2020 16:59
@Quentame Quentame changed the title WIP : Add config flow to Freebox Add config flow to Freebox Jan 11, 2020
@Quentame Quentame mentioned this pull request Jan 11, 2020
Merged
2 tasks
This was referenced Jan 11, 2020
Merged
Merged
@Quentame Quentame removed their assignment Jan 11, 2020
@Quentame Quentame force-pushed the freebox/config-flow branch from afa170d to b509cec Compare January 11, 2020 22:27
@Quentame Quentame mentioned this pull request Jan 17, 2020
Merged
6 tasks
@Quentame Quentame force-pushed the freebox/config-flow branch 2 times, most recently from 6d5b487 to 0849f5e Compare January 19, 2020 23:20
@Quentame Quentame force-pushed the freebox/config-flow branch from d539f8d to b3d67bf Compare March 11, 2020 12:25
@Quentame Quentame requested a review from MartinHjelmare March 11, 2020 12:27
MartinHjelmare
MartinHjelmare reviewed Mar 11, 2020
View reviewed changes
Comment thread homeassistant/components/freebox/router.py Outdated
Comment thread homeassistant/components/freebox/router.py Outdated
@Quentame Quentame requested a review from MartinHjelmare March 11, 2020 18:15
MartinHjelmare
MartinHjelmare approved these changes Mar 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Mar 11, 2020

Can we merge here or do we need to wait for the frontend PR?

@Quentame
Copy link
Copy Markdown
Member Author

Quentame commented Mar 11, 2020 •
edited
Loading

Don't know the order, the PR is written as "wait for backend" home-assistant/frontend#4448

@Quentame
Copy link
Copy Markdown
Member Author

Quentame commented Mar 11, 2020

Should be front then back, then doc I guess

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Mar 11, 2020

Ok. Please check with frontend team. I'll leave this here for now. It can be merged when ready.

@Quentame
Copy link
Copy Markdown
Member Author

Quentame commented Mar 11, 2020

Thanks 🙏

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Mar 11, 2020

Frontend merged

@bramkragten bramkragten merged commit 19be4a5 into home-assistant:dev Mar 11, 2020
@Quentame Quentame deleted the freebox/config-flow branch March 11, 2020 21:17
@lock lock Bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

+1 more reviewer

@SNoof85 SNoof85 SNoof85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change cla-signed has-tests integration: freebox

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Quentame @SNoof85 @MartinHjelmare @bramkragten @homeassistant