Add config flow to Meteo-France by Quentame · Pull Request #29927 · home-assistant/core

Quentame · 2019-12-13T23:41:58Z

Breaking Change:

No more monitored_conditions, all sensors will be added --> ADR-03

Description:

Adding config flow to Météo-France

Pull request with documentation for home-assistant.io : home-assistant/home-assistant.io#11474

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

probot-home-assistant · 2019-12-13T23:42:09Z

Hey there @victorcerutti, @oncleben31, mind taking a look at this pull request as its been labeled with a integration (meteo_france) you are listed as a codeowner for? Thanks!

Quentame · 2020-01-10T21:38:54Z

@springstan if you have a little time, I will appreciated a review, and why not an approval 😉

springstan

@Quentame I have found some time to look over your code, please see my review comments for more information 😊

Quentame · 2020-01-11T18:21:51Z

Thanks a lot for taking your time on my PR and for your review @springstan

springstan · 2020-01-11T19:03:28Z

Of course @Quentame, no problem at all.

springstan

LGTM 🎉

…]_[sensor_type]. Platform meteo_france does not generate unique IDs - when multiple district in one city

Quentame · 2020-02-03T18:29:06Z

+        update=False,
+    ) as service_mock:
+        service_mock.return_value.get_data.return_value = {"name": CITY_2_NAME}
+        yield service_mock


@MartinHjelmare Is it possible to make conditional tests with MagicMock ?

That would be like :

if service_mock.return_value.postal_code == CITY_1_POSTAL: service_mock.return_value.get_data.return_value = {"name": CITY_1_NAME} else if service_mock.return_value.postal_code == CITY_2_POSTAL: service_mock.return_value.get_data.return_value = {"name": CITY_2_NAME}

Looked but can't find.

Depends on what the attributes on the mock return. By default they return mocks, so they need to be set or specced by something.

MartinHjelmare · 2020-02-03T19:09:28Z

Make sure to update the breaking change paragraph.

Ping me when that is done and the tests are ready and I'll have a final look.

Quentame · 2020-02-03T19:35:08Z

@MartinHjelmare Documentation updated + breaking change paragraph updated + tests passing 😊

MartinHjelmare

Looks good! Just some small comments.

Quentame · 2020-02-04T12:09:22Z

Tested with import :

meteo_france:
  - city: Paris
  - city: '75001'
  - city: '75004'
  - city: '75009'
  - city: Lyon
  - city: '69001'
  - city: '69004'
  - city: '69009'
  - city: '74220'

And needed a little more fix.

codecov · 2020-02-04T13:31:34Z

Codecov Report

Merging #29927 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##              dev   #29927    +/-   ##
========================================
  Coverage   94.62%   94.62%            
========================================
  Files         749      750     +1     
  Lines       54193    54313   +120     
========================================
+ Hits        51278    51393   +115     
- Misses       2915     2920     +5

Impacted Files	Coverage Δ
homeassistant/components/samsungtv/config_flow.py	`98.19% <0.00%> (-0.80%)`	⬇️
homeassistant/components/alexa/capabilities.py	`93.37% <0.00%> (-0.19%)`	⬇️
homeassistant/components/template/light.py	`97.69% <0.00%> (-0.16%)`	⬇️
...meassistant/components/meteo_france/config_flow.py	`100.00% <0.00%> (ø)`
homeassistant/components/alexa/entities.py	`98.50% <0.00%> (+<0.01%)`	⬆️
homeassistant/components/samsungtv/media_player.py	`96.57% <0.00%> (+0.14%)`	⬆️
homeassistant/components/homematicip_cloud/hap.py	`84.76% <0.00%> (+0.41%)`	⬆️
homeassistant/components/derivative/sensor.py	`88.63% <0.00%> (+1.45%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c997e...90c63f9. Read the comment docs.

MartinHjelmare

Nice!

homeassistant added the cla-signed label Dec 13, 2019

probot-home-assistant Bot added has-tests integration: meteo_france labels Dec 13, 2019

frenck added the docs-missing label Dec 16, 2019

Quentame force-pushed the meteo_france/config-flow branch from 8d1b15d to 96a78be Compare December 16, 2019 21:45

Quentame mentioned this pull request Dec 16, 2019

Add config flow to Meteo-France home-assistant/home-assistant.io#11474

Merged

2 tasks

frenck removed the docs-missing label Dec 18, 2019

Quentame force-pushed the meteo_france/config-flow branch from 96a78be to 28f3f9d Compare December 21, 2019 21:21

Quentame force-pushed the meteo_france/config-flow branch 3 times, most recently from e1daff0 to ed718c1 Compare January 8, 2020 12:58

springstan requested changes Jan 11, 2020

View reviewed changes

Comment thread homeassistant/components/meteo_france/config_flow.py Outdated

Comment thread homeassistant/components/meteo_france/config_flow.py Outdated

Comment thread homeassistant/components/meteo_france/__init__.py Outdated

springstan approved these changes Jan 11, 2020

View reviewed changes

Quentame mentioned this pull request Jan 17, 2020

Fix can't add multiple iCloud accounts (remove account name) #30898

Merged

6 tasks

Quentame force-pushed the meteo_france/config-flow branch from 157a7f1 to e1610df Compare January 27, 2020 13:02

MartinHjelmare requested changes Feb 2, 2020

View reviewed changes

Quentame commented Feb 3, 2020

View reviewed changes

Comment thread tests/components/meteo_france/test_config_flow.py Outdated

Quentame added 8 commits February 3, 2020 15:39

Add config flow to Meteo-France

505efca

Review 1

309ede5

Use config_entry.unique_id

dde52eb

Fix config_flow _show_setup_form + init

4133f06

Remove empty *_setup_platform()

a321cad

Avoid HomeAssistantError: Entity id already exists: sensor.[city_name…

227a5e4

…]_[sensor_type]. Platform meteo_france does not generate unique IDs - when multiple district in one city

Review + abort when API error

59e10c5

Fix I/O

bd7ffb4

Quentame force-pushed the meteo_france/config-flow branch from e1610df to bd7ffb4 Compare February 3, 2020 14:39

Quentame added 2 commits February 3, 2020 16:07

Remove monitored_conditions

e74ad0c

Add async_unload_entry

b02122e

Quentame requested a review from MartinHjelmare February 3, 2020 15:15

MartinHjelmare reviewed Feb 3, 2020

View reviewed changes

Comment thread homeassistant/components/meteo_france/config_flow.py Outdated

Comment thread homeassistant/components/meteo_france/sensor.py Outdated

Comment thread homeassistant/components/meteo_france/__init__.py Outdated

Comment thread homeassistant/components/meteo_france/__init__.py Outdated

Quentame commented Feb 3, 2020

View reviewed changes

Quentame added 3 commits February 3, 2020 19:40

Review 3

b6d6a86

Fix pipe

d1c314d

alert_watcher is already None

5c70341

Quentame requested a review from MartinHjelmare February 3, 2020 19:04

MartinHjelmare added the breaking-change label Feb 3, 2020

MartinHjelmare reviewed Feb 3, 2020

View reviewed changes

Comment thread homeassistant/components/meteo_france/__init__.py

Comment thread homeassistant/components/meteo_france/manifest.json

Comment thread homeassistant/components/meteo_france/weather.py

Comment thread tests/components/meteo_france/test_config_flow.py Outdated

Quentame added 2 commits February 4, 2020 12:47

Review 4

8297fdc

Better fix for "Entity id already exists"

4249ac0

Quentame requested a review from MartinHjelmare February 4, 2020 12:44

Whoops, fix tests

90c63f9

MartinHjelmare reviewed Feb 4, 2020

View reviewed changes

Comment thread homeassistant/components/meteo_france/strings.json Outdated

Fix string

fc159c4

Quentame requested a review from MartinHjelmare February 4, 2020 19:04

MartinHjelmare approved these changes Feb 4, 2020

View reviewed changes

MartinHjelmare merged commit 201ea25 into home-assistant:dev Feb 4, 2020

Quentame deleted the meteo_france/config-flow branch February 4, 2020 21:44

lock Bot locked and limited conversation to collaborators Feb 5, 2020

Uh oh!

Conversation

Quentame commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Checklist:

Uh oh!

probot-home-assistant Bot commented Dec 13, 2019

Uh oh!

Quentame commented Jan 10, 2020

Uh oh!

springstan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Quentame commented Jan 11, 2020

Uh oh!

springstan commented Jan 11, 2020

Uh oh!

springstan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Quentame Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Feb 3, 2020

Uh oh!

Quentame commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Quentame commented Feb 4, 2020

Uh oh!

codecov Bot commented Feb 4, 2020

Codecov Report

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Quentame commented Dec 13, 2019 •

edited

Loading

springstan left a comment •

edited

Loading

Quentame commented Feb 3, 2020 •

edited

Loading