Refactor Freebox : add config flow + temperature sensor + signal dispatch#11712
Conversation
probot-home-assistant
Bot
added
has-parent
Quentame
force-pushed
the
freebox/config-flow
branch
2 times, most recently
from
6ca3a5e to
5f59e72
Compare
| <div class='note warning'> | ||
|
|
||
| If you change your Freebox router for a new one, you need to delete the `freebox.conf` file located in your Home Assistant configuration directory to make the association again. | ||
| If you change your Freebox router for a new one, go into your Home Assistant configuration `.storage` folder and delete the "freebox" folder, then add the component again. |
There was a problem hiding this comment.
| If you change your Freebox router for a new one, go into your Home Assistant configuration `.storage` folder and delete the "freebox" folder, then add the component again. | |
| If you change your Freebox router for a new one, go into your Home Assistant configuration `.storage` folder and delete the "freebox" folder, then add the integration again. |
Besides, this sounds weird. Shouldn't the user just delete the integration via the UI and re-add it? The cleanup of the storage folder can be done automatically as part of the unload procedure right?
There was a problem hiding this comment.
That would be nice actually. I didn't know something was planned to clean up the storage folder.
Will see (and for the iCloud integration), not in the PR for now, will see and update here as soon as it's get coded 😉.
Maybe in a new PR perhaps, there is already a lot in this one.
There was a problem hiding this comment.
? I'm not saying it happens automatically, but there is an integration unload method that allows you do those things right?
I think we should never instruct the user to go into their .storage folder.
There was a problem hiding this comment.
I understood not automatically.
I thought the helpers.storage.Store has a function that can clear itself (depending on the STORAGE_KEY of course) and I could call this function on the async_unload_entry of the integration.
I completely agree that the user shouldn't go to the .storage folder (there is a reason why it is invisible).
In fact I've updated the location here but during my development and test, I didn't need to remove the conf file at all. Before, the token file was freebox.conf, now it's f"{freebox_dir.path}/{slugify(self._host)}.conf" : since the host will change with a new Freebox, I don't think this note is still necessary.
frenck
added
new-feature
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
frenck
added
awaits-parent
Quentame
force-pushed
the
freebox/config-flow
branch
from
0e6ce83 to
5133e3c
Compare
|
Rebased to trigger the new pipeline. |
Quentame
force-pushed
the
freebox/config-flow
branch
from
5133e3c to
79370ca
Compare
Quentame
force-pushed
the
freebox/config-flow
branch
from
79370ca to
a09d133
Compare
|
Parent PR ready home-assistant/core#30334 🎉 |
Quentame
changed the title
probot-home-assistant
Bot
added
the
parent-merged
probot-home-assistant
Bot
removed
the
awaits-parent
probot-home-assistant
Bot
removed
the
parent-merged
…-assistant#11712) * Add config flow to Freebox * ✏️ Tweak * Review from frenck Co-authored-by: Klaas Schoute <klaas_schoute@hotmail.com>
3 participants
Description:
Follows home-assistant/core#30334
Pull request in home-assistant (if applicable): home-assistant/core#30334
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.