Add vera config entries support by vangorra · Pull Request #29880 · home-assistant/core

vangorra · 2019-12-12T15:29:13Z

Breaking Change:

None

Description:

Adding config entries support to vera component.

Related issue (if applicable): None

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11663

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

MartinHjelmare

We also need tests for the config flow.

frenck · 2019-12-15T17:26:57Z

Added the docs-missing label. Documentation needs to be adjusted for this change.

frenck · 2019-12-15T17:28:19Z

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

vangorra · 2019-12-16T15:58:11Z

@frenck What sorts of documentation are needed? This change only adds config entries support, it doesn't change the config structure for the component.

springstan · 2019-12-16T19:55:56Z

@vangorra I think the smartthings integration documentation is a good example for that.
Hope this helps you :)

vangorra · 2019-12-16T21:04:30Z

The vera integration already has sufficient documentation here: https://www.home-assistant.io/integrations/vera/
I don't see how this change would effect the existing documentation.

vangorra · 2019-12-23T16:13:03Z

What additional changes are needed? The documentation request is not particularly clear.

cogneato · 2019-12-29T14:39:18Z

You would want to add that is is available as an integration like the smartthings example provided earlier.

stale · 2020-03-21T16:27:38Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

MartinHjelmare

Please rebase on latest dev branch.

Addressing PR feedback regarding creation of controller and scheduling of async config flow actions.

Fixing some PR feedback.

PR feedback changes.

Disabling config through UI if config is provided from a file. More tests to account for these adjustments.

Adding more tests.

Addressing additional PR feedback.

Addressing feedback.

MartinHjelmare

Great!

mrand · 2020-04-03T13:14:04Z

I'm sorry, I can't determine - will the integration import existing yaml configs? Will entity id's be the same with the integration as they were with yaml configs? If not, and there is no way to migrate, I hope this gets extra bold notes in the breaking changes because people with large Z-wave networks will need to plan for such a big change.

vangorra · 2020-04-03T13:43:38Z

This integration WILL import existing yaml configs. Entity ids WILL remain the same as they always have. No breaking changes.

homeassistant added the cla-signed label Dec 12, 2019

probot-home-assistant Bot added has-tests integration: vera labels Dec 12, 2019

vangorra mentioned this pull request Dec 12, 2019

Adding vera device info support. #29859

Closed

9 tasks

MartinHjelmare requested changes Dec 12, 2019

View reviewed changes

Comment thread homeassistant/components/vera/common.py Outdated

MartinHjelmare changed the title ~~Adding vera config entries support.~~ Add vera config entries support Dec 12, 2019

MartinHjelmare reviewed Dec 13, 2019

View reviewed changes

Comment thread homeassistant/components/vera/common.py Outdated

Comment thread homeassistant/components/vera/common.py

MartinHjelmare requested changes Dec 14, 2019

View reviewed changes

frenck added the docs-missing label Dec 15, 2019

MartinHjelmare reviewed Dec 15, 2019

View reviewed changes

Comment thread homeassistant/components/vera/__init__.py Outdated

Comment thread homeassistant/components/vera/config_flow.py Outdated

MartinHjelmare reviewed Dec 15, 2019

View reviewed changes

Comment thread homeassistant/components/vera/config_flow.py Outdated

Comment thread homeassistant/components/vera/__init__.py Outdated

vangorra mentioned this pull request Jan 7, 2020

Updating vera docs to use config flow in related pr. home-assistant/home-assistant.io#11663

Merged

2 tasks

MartinHjelmare reviewed Jan 7, 2020

View reviewed changes

Comment thread homeassistant/components/vera/config_flow.py

Comment thread homeassistant/components/vera/config_flow.py Outdated

Comment thread tests/components/vera/test_config_flow.py Outdated

MartinHjelmare reviewed Jan 7, 2020

View reviewed changes

Comment thread homeassistant/components/vera/config_flow.py Outdated

MartinHjelmare reviewed Jan 8, 2020

View reviewed changes

Comment thread homeassistant/components/vera/config_flow.py Outdated

Comment thread homeassistant/components/vera/config_flow.py Outdated

Comment thread tests/components/vera/test_config_flow.py Outdated

Comment thread homeassistant/components/vera/__init__.py

MartinHjelmare reviewed Jan 9, 2020

View reviewed changes

Comment thread homeassistant/components/vera/__init__.py Outdated

MartinHjelmare reviewed Jan 9, 2020

View reviewed changes

Comment thread homeassistant/components/vera/__init__.py Outdated

Comment thread homeassistant/components/vera/config_flow.py Outdated

MartinHjelmare reviewed Jan 11, 2020

View reviewed changes

Comment thread homeassistant/components/vera/__init__.py Outdated

Comment thread homeassistant/components/vera/config_flow.py Outdated

Comment thread tests/components/vera/test_init.py Outdated

Comment thread tests/components/vera/test_init.py Outdated

MartinHjelmare reviewed Jan 11, 2020

View reviewed changes

Comment thread tests/components/vera/test_init.py Outdated

MartinHjelmare reviewed Jan 11, 2020

View reviewed changes

Comment thread homeassistant/components/vera/strings.json Outdated

MartinHjelmare reviewed Jan 12, 2020

View reviewed changes

Comment thread homeassistant/components/vera/config_flow.py Outdated

stale Bot added the stale label Mar 21, 2020

MartinHjelmare reviewed Mar 21, 2020

View reviewed changes

Comment thread homeassistant/components/vera/config_flow.py Outdated

vangorra added 20 commits March 29, 2020 07:25

Adding vera config entries support.

15f28a1

Fixing lint error.

94382a7

Applying minimal changes necessary to get config entries working.

07ec5bf

Addressing PR feedback by further reducing the scope of the change.

6460f21

Addressing PR feedback.

db0840a

Fixing pyvera import to make it easier to patch.

eb71881

Addressing PR feedback regarding creation of controller and scheduling of async config flow actions.

Updating code owners file.

251ba61

Small fixes.

d6e4784

Adding a user config flow step.

30eb170

Adding optional configs for user config flow.

29aeab7

Updating strings to be more clear to the user.

232fb18

Adding options flow.

d590c8d

Fixing some PR feedback.

Better handling of options.

c233a25

PR feedback changes.

Using config registry to update config options.

6bb7f10

Better managing config from file or config from UI

5797c6c

Disabling config through UI if config is provided from a file. More tests to account for these adjustments.

Address PR feedback.

62a5667

Fixing test, merging with master.

aa95209

Disabling all Vera UI for configs managed by configuration.yml.

91140f6

Adding more tests.

Updating config based on unique_id.

bf8f5f9

Addressing additional PR feedback.

Rebasing off dev.

db1010f

Addressing feedback.

MartinHjelmare reviewed Mar 29, 2020

View reviewed changes

MartinHjelmare removed the docs-missing label Mar 29, 2020

Addressing PR feedback.

3d12eee

MartinHjelmare approved these changes Apr 3, 2020

View reviewed changes

MartinHjelmare merged commit ae22b51 into home-assistant:dev Apr 3, 2020

vangorra deleted the vangorra_vera_config_entries branch April 3, 2020 13:44

lock Bot locked and limited conversation to collaborators Apr 4, 2020

Uh oh!

Conversation

vangorra commented Dec 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking Change:

Description:

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frenck commented Dec 15, 2019

Uh oh!

frenck commented Dec 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vangorra commented Dec 16, 2019

Uh oh!

springstan commented Dec 16, 2019

Uh oh!

vangorra commented Dec 16, 2019

Uh oh!

vangorra commented Dec 23, 2019

Uh oh!

cogneato commented Dec 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stale Bot commented Mar 21, 2020

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

mrand commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

vangorra commented Dec 12, 2019 •

edited

Loading

cogneato commented Dec 29, 2019 •

edited

Loading

mrand commented Apr 3, 2020 •

edited

Loading

vangorra commented Apr 3, 2020 •

edited

Loading