Skip to content

Adding vera device info support.#29859

Closed
vangorra wants to merge 1 commit intohome-assistant:devfrom
vangorra:vangorra_vera_device_info
Closed

Adding vera device info support.#29859
vangorra wants to merge 1 commit intohome-assistant:devfrom
vangorra:vangorra_vera_device_info

Conversation

@vangorra
Copy link
Copy Markdown
Contributor

@vangorra vangorra commented Dec 12, 2019

Breaking Change:

None

Description:

Adding device info support to vera device entity.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

return self.vera_device.should_poll

@property
def device_info(self):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device info requires a config entry to be used. Please submit this PR after the config entries PR.

https://developers.home-assistant.io/docs/en/device_registry_index.html#defining-devices

@vangorra
Copy link
Copy Markdown
Contributor Author

Config entries PR is here: #29880
Will resubmit this PR once the config entries PR is merged.

@vangorra vangorra closed this Dec 12, 2019
@vangorra vangorra deleted the vangorra_vera_device_info branch December 12, 2019 15:30
@lock lock Bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants