Skip to content

Updating vera docs to use config flow in related pr.#11663

Merged
frenck merged 6 commits into
home-assistant:nextfrom
vangorra:vangorra_vera_config_flow
Apr 3, 2020
Merged

Updating vera docs to use config flow in related pr.#11663
frenck merged 6 commits into
home-assistant:nextfrom
vangorra:vangorra_vera_config_flow

Conversation

@vangorra
Copy link
Copy Markdown
Contributor

@vangorra vangorra commented Jan 7, 2020

Description:
Changing documentation to prefer config flow instead of configuration.yml.

Pull request in home-assistant (if applicable): home-assistant/core#29880

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Jan 7, 2020
Comment thread source/_integrations/vera.markdown Outdated
<div class='note info'>

To use Vera devices in your installation, add the following to your configuration.yaml file using the IP and port number of your Vera controller:
The Vera integration is configured exclusively through the front-end. Manual setup through `configuration.yaml` is deprecated.
Copy link
Copy Markdown
Member

@frenck frenck Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let not make big warnings. Those are for the release notes and changelogs that go with the releases.

Instead, we should write the documentation for a new user getting here. What does he has to click and do to make it work?

Please write the documentation from a new user perspective.

EDIT: 🤦‍♂ Sorry about that. That is incorrect judgment, I need to call it a day. 😉

However, let's remove this warning.

@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration in-progress This PR/Issue is currently being worked on labels Jan 7, 2020
@frenck frenck assigned vangorra and unassigned vangorra Jan 7, 2020
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Jan 8, 2020
frenck
frenck previously approved these changes Jan 8, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 8, 2020
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Apr 3, 2020
@vangorra
Copy link
Copy Markdown
Contributor Author

vangorra commented Apr 3, 2020

Rebased and linked PR is merged. This should be ready to merge once build finishes.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck frenck merged commit 43f0dc0 into home-assistant:next Apr 3, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Apr 3, 2020
@vangorra vangorra deleted the vangorra_vera_config_flow branch April 3, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants