Skip to content

Add battery sensor to iCloud#11434

Merged
frenck merged 2 commits into
home-assistant:nextfrom
Quentame:icloud/add-battery-sensor
Dec 16, 2019
Merged

Add battery sensor to iCloud#11434
frenck merged 2 commits into
home-assistant:nextfrom
Quentame:icloud/add-battery-sensor

Conversation

@Quentame
Copy link
Copy Markdown
Member

Description:

Follows home-assistant/core#29818

Pull request in home-assistant : home-assistant/core#29818

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Dec 11, 2019
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Dec 12, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Quentame!

I reviewed it, and left a couple of small comments. Could you take a look? Thanks! 👍

Comment thread source/_integrations/icloud.markdown Outdated
Comment thread source/_integrations/icloud.markdown Outdated
Comment thread source/_integrations/icloud.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Dec 12, 2019
@Quentame
Copy link
Copy Markdown
Member Author

Will do very soon 😌

Thanks

Comment thread source/_integrations/icloud.markdown Outdated
Quentame added a commit to Quentame/home-assistant.io that referenced this pull request Dec 12, 2019
@Quentame Quentame removed their assignment Dec 12, 2019
@Quentame Quentame requested a review from frenck December 12, 2019 12:49
@Quentame Quentame mentioned this pull request Dec 12, 2019
2 tasks
frenck pushed a commit that referenced this pull request Dec 12, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 12, 2019

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Dec 12, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Dec 14, 2019
@frenck frenck merged commit e889cf7 into home-assistant:next Dec 16, 2019
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Dec 16, 2019
@Quentame Quentame deleted the icloud/add-battery-sensor branch December 16, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants