Add Unifi Led#27475
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dshokouhi
left a comment
There was a problem hiding this comment.
Just a couple of comments based on my experience from PR's I submitted
florisvdk
left a comment
There was a problem hiding this comment.
Everything noted should be fixed.
|
@dshokouhi If you can have a look at the changes i did it would be greatly appreciated. |
dshokouhi
left a comment
There was a problem hiding this comment.
Looks good to me, will need an approval from someone who has merge rights to move forward.
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good! Some small changes needed.
|
Please run black code formatter from the project root. |
|
This is what i get: And i get the same without the fast option. |
|
And there are no changes in your local branch that aren't pushed yet to the PR? |
|
No changes that are not committed and pushed. |
|
I am not finding the thing it is failing on, all the commands i try return that it is good. |
|
The last commit is the same as a previous one that did not fail so something is broken. |
|
@MartinHjelmare Looks like this is the cause of the issue: #28171 |
|
The PR to fix the formatting is merged. Try rebasing on latest dev branch to let the build pass. |
Description:
Added Ubiquiti Unifi LED basic light platform (On/Off and brightness)
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10720
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: