Add documentation for Unifi LED integration#10720
Merged
Merged
Conversation
probot-home-assistant
Bot
added
current
9 tasks
probot-home-assistant
Bot
added
the
has-parent
klaasnicolaas
requested changes
Oct 11, 2019
Member
klaasnicolaas
left a comment
klaasnicolaas
left a comment
There was a problem hiding this comment.
I left som comments, btw please rebase this PR to the next branch.
klaasnicolaas
added
in-progress
probot-home-assistant
Bot
added
next
Contributor
Author
|
I think i messed something up with the rebasing. I am new to a lot of this. Is this fixable or do i make a new pull request? |
Member
|
Now you only chaged the target branch, but you must also rebase the |
Fixed marked issues The option "Id" is going to be removed in the integration, making a commit for that after this. Added . to end of line
Contributor
Author
|
Finally figured it out, Thanks for putting up with this. |
klaasnicolaas
requested changes
Oct 11, 2019
Member
|
Good to see that you have succeeded in solving the problem, with a few small comments left we can approve it 😉 |
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
Contributor
Author
|
Made a new commit to fix the settings in the integration code. |
klaasnicolaas
removed
in-progress
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
Contributor
Author
|
@klaasnicolaas I fixed the things you asked for. |
klaasnicolaas
previously approved these changes
Oct 19, 2019
rytilahti
reviewed
Oct 23, 2019
| required: true | ||
| default: None | ||
| port: | ||
| description: Port used to connect to the Unifi LED controller. |
Member
There was a problem hiding this comment.
Is it necessary to make this configurable at all? Other than that, description such as Control Port, Login username would be shorter and easier to read.
probot-home-assistant
Bot
added
the
parent-merged
frenck
approved these changes
Nov 6, 2019
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
Thanks, @florisvdk! 👍 Sorry for the long wait! 🙏
probot-home-assistant
Bot
removed
awaits-parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added unifiled integration documentation in preparation of making a pull request for it.
Pull request in home-assistant (if applicable): home-assistant/core#27475
Checklist:
nextis for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.