Skip to content

Add available to unifiled lights#27659

Closed
florisvdk wants to merge 9 commits into
home-assistant:devfrom
florisvdk:unifiled-available
Closed

Add available to unifiled lights#27659
florisvdk wants to merge 9 commits into
home-assistant:devfrom
florisvdk:unifiled-available

Conversation

@florisvdk
Copy link
Copy Markdown
Contributor

Breaking Change:

Description:

Added the available state to the Unifi LED lights
Updated pypi library version
This is a continuation on #27475

Example entry for configuration.yaml (if applicable):

light:
  - platform: unifiled
    host: 192.168.1.20
    port: 20443
    username: ubnt
    password: ubnt

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Oct 15, 2019

Please don't open more than one PR at a time for the same integration.

Wait until the other first PR is merged.

@florisvdk
Copy link
Copy Markdown
Contributor Author

My bad, i asked about this on the discord and from the answer i got there i thought it was allowed. I will not do it again.

@MartinHjelmare MartinHjelmare changed the title add available to ligts in unifiled Add available to unifiled lights Oct 17, 2019
@florisvdk florisvdk closed this Oct 24, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants