Skip to content

Whitelist yeelight predefined effects per device type#22979

Closed
zewelor wants to merge 8 commits into
home-assistant:devfrom
zewelor:whitelist_yeelight_predefined_effects_per_device_type
Closed

Whitelist yeelight predefined effects per device type#22979
zewelor wants to merge 8 commits into
home-assistant:devfrom
zewelor:whitelist_yeelight_predefined_effects_per_device_type

Conversation

@zewelor
Copy link
Copy Markdown
Contributor

@zewelor zewelor commented Apr 10, 2019

Description:

Enabled effects for each device, according to what it supports

Its based on #22547, will rebase after merging.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@github-actions
Copy link
Copy Markdown

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (yeelight) you are listed as a codeowner for? Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2019

Codecov Report

Merging #22979 into dev will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22979      +/-   ##
==========================================
- Coverage   93.98%   93.83%   -0.16%     
==========================================
  Files         449      448       -1     
  Lines       36768    36528     -240     
==========================================
- Hits        34558    34275     -283     
- Misses       2210     2253      +43
Impacted Files Coverage Δ
homeassistant/components/mqtt/light/schema_json.py 73.06% <0%> (-20.67%) ⬇️
homeassistant/components/homekit/util.py 99.05% <0%> (-0.95%) ⬇️
homeassistant/bootstrap.py 58.08% <0%> (-0.71%) ⬇️
homeassistant/helpers/service.py 93.19% <0%> (-0.08%) ⬇️
homeassistant/components/mqtt/climate.py 99.43% <0%> (-0.07%) ⬇️
homeassistant/helpers/entity_component.py 96.18% <0%> (-0.03%) ⬇️
homeassistant/components/demo/media_player.py 95.42% <0%> (ø) ⬆️
homeassistant/components/homekit/accessories.py 100% <0%> (ø) ⬆️
...assistant/components/mqtt/light/schema_template.py 80.27% <0%> (ø) ⬆️
homeassistant/components/homekit/const.py 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7624d0e...e60fdb8. Read the comment docs.

@majuss
Copy link
Copy Markdown
Contributor

majuss commented Apr 13, 2019

Will this bring support for night-mode on the ceilings lights?

@zewelor
Copy link
Copy Markdown
Contributor Author

zewelor commented Apr 13, 2019

Night mode is already supported via service call: https://www.home-assistant.io/components/yeelight/#service-yeelightset_mode . There is also other PR that handles night mode via special light entity: #22936

@zewelor
Copy link
Copy Markdown
Contributor Author

zewelor commented Jun 15, 2019

Closing in favor of: #24544

@zewelor zewelor closed this Jun 15, 2019
@zewelor zewelor deleted the whitelist_yeelight_predefined_effects_per_device_type branch June 15, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants