Skip to content

Add yeelight nighlight support with separate light entity#22936

Closed
zewelor wants to merge 9 commits into
home-assistant:devfrom
zewelor:add_yeelight_nighlight_support_redux
Closed

Add yeelight nighlight support with separate light entity#22936
zewelor wants to merge 9 commits into
home-assistant:devfrom
zewelor:add_yeelight_nighlight_support_redux

Conversation

@zewelor
Copy link
Copy Markdown
Contributor

@zewelor zewelor commented Apr 9, 2019

Description:

Added option to create separate light entity, for better nightlight mode switch UX. By default option is off, so its opt in.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

yeelight:
  devices:
    192.168.1.132:
      name: Wall light bedroom
      nightlight_switch_type: light

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2019

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (yeelight) you are listed as a codeowner for? Thanks!

@rytilahti
Copy link
Copy Markdown
Member

This is waiting for #22547 and may require rebasing after that gets merged.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 18, 2019

#22547 has been merged. Please rebase and address linting issues.

@balloob balloob closed this Aug 21, 2019
@zewelor zewelor deleted the add_yeelight_nighlight_support_redux branch August 27, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants