Whitelist yeelight predefined effects per device type#24544
Merged
rytilahti merged 2 commits intoJun 16, 2019
Merged
Conversation
ghost
assigned
|
Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
3 tasks
amelchio
reviewed
Jun 15, 2019
| SUPPORT_COLOR | | ||
| SUPPORT_EFFECT | | ||
| SUPPORT_YEELIGHT_RGB = (SUPPORT_YEELIGHT_WHITE_TEMP | | ||
| SUPPORT_COLOR_TEMP) |
Contributor
There was a problem hiding this comment.
You removed SUPPORT_COLOR, not SUPPORT_COLOR_TEMP.
Member
|
LGTM, can be merged after the checks are completed 👍 |
rytilahti
approved these changes
Jun 16, 2019
zewelor
deleted the
whitelist_yeelight_predefined_effects_per_device_type_redux
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Whitelist effects that are really supported by different devices. For example ceiling lights ( except ambilight ceiling ) can support temp and brightness only effects.
Checklist:
tox. Your PR cannot be merged unless tests pass