Update enigma2 based on review comments#21890
Merged
Merged
Conversation
homeassistant
added
cla-signed
integration: discovery
small-pr
ghost
added
the
MartinHjelmare
requested changes
Mar 10, 2019
MartinHjelmare
changed the title
Member
|
Can be merged when build passes. |
Merged
|
I get error: |
Contributor
Author
|
Looks like you don’t have OpenWebIf installed. You have Webif which is xml based and not supported by this component. If you need to discuss further please open a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There were some extra comments rasied by @MartinHjelmare after my Enigma2 component got merged, so this PR is to address those.
2.4.0since this includes Enigma2 discovery in PR Bump netdisco to 2.4.0 #21914. Thanks @balloob for the bump on that.Related issue (if applicable): fixes #21271
Checklist:
tox. Your PR cannot be merged unless tests pass