Add support for Stiebel Eltron heat pumps

[fucm]

Description:

Add initial support for a Stiebel Eltron component to support heat pumps with ISGWeb Modbus module.

It supports the climate platform currently and is prepared to add the sensor platform later on.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8763

Example entry for configuration.yaml (if applicable):

modbus:
  type: tcp
  host: 192.168.1.20
  port: 502

stiebel_eltron:
  name: LWZ504e

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• It does.

To do:

• Run script script/manifest/codeowners.py
• Resolve conflict files
• Update docs with state mappings

[fucm]

WIP removed. Please review the state translation. I did not manage to get it working locally, even if it should be implemented as specified by the documentation.

[MartinHjelmare]

Please add a manifest file.

See eg https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/hue/manifest.json.

[fucm]

Manifest file added. Can I remove the entry from CODEOWNERS?

[fucm]

I will resolve the conflicting files, after the review issues have been resolved.

[MartinHjelmare]

The codeowners file should be automatically populated with info from the manifest file when running the script script/manifest/codeowners.py.

[fucm]

I will update the docs (for the state mappings) as soon as this review is done.

Some questions

• Should I mark the conversations as resolved or is this your job in the review process?
• Am I allowed to remove the in progress label?

BTW: Thanks!

[MartinHjelmare]

You can resolve the comments when you think they are resolved. I'll unresolve if I disagree. 👍

The in progress label is handled automatically by a bot. Don't worry about it.

[fucm]

All done. I hope the code is ready now.

[MartinHjelmare]

Probably try to rebase again to fix .coveragerc.

[MartinHjelmare]

Looks good!

Please add the integration component package to .coveragerc. Minor comment below too.

[fucm]

.coveragerc is updated.

Question: is the temperature conversion to Fahrenheit handled by the core or does it need to be implemented by the platform?

[MartinHjelmare]

Yes, the temperature unit conversion is handled by the core.

[MartinHjelmare]

Great!

[MartinHjelmare]

Can be merged when build passes.

[fucm]

What's the normal waiting time for a build check? Is 3 days normal?

[MartinHjelmare]

I've restarted the workflow on circleci. Let's see what happens.

[MartinHjelmare]

Sorry. We're in the middle of a major refactor. Please remove requirements and dependencies constants in the component.

[MartinHjelmare]

Thanks!