Initial STIEBEL ELTRON documentation#8763
Merged
Merged
Conversation
ghost
added
the
11 tasks
frenck
added
new-integration
Member
klaasnicolaas
left a comment
klaasnicolaas
left a comment
There was a problem hiding this comment.
The config variables do not match those in the parent PR.
In the python code I see name as required and hub as optional. In the documentation you have both set as optional.
klaasnicolaas
requested changes
Apr 9, 2019
Contributor
Author
|
home-assistant PR is ready to be merged. Can this be approved as well? |
MartinHjelmare
previously approved these changes
Apr 14, 2019
klaasnicolaas
previously approved these changes
Apr 14, 2019
klaasnicolaas
approved these changes
Apr 15, 2019
Member
|
Thnx for the PR! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add initial STIEBEL ELTRON documentation.
Pull request in home-assistant (if applicable): home-assistant/core#21199
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.