Nissanleaf#21145
Conversation
|
Please rebase the branch on latest dev, so only the new commits after the last PR was merged are in this branch. |
|
For charging I think a custom service in the component + a sensor or binary sensor entity that exposes charging status sounds good. |
| # Maybe it should be a scene? | ||
| # Unsure if better to provide as a sensor for the state, and a service to | ||
| # start a charge, e.g. | ||
| # - service: nissan_leaf.start_charging |
There was a problem hiding this comment.
Yes! Service + sensor is a good idea! 👍
The service should be registered in the nissan_leaf component.
There was a problem hiding this comment.
Converted to a service and sensor in commit 9fa7369
|
Please link a docs PR with the update for the new service. |
|
Here's the PR for the updated docs that include the new service, home-assistant/home-assistant.io#8630 |
|
Thanks for this great new component! I'm testing it now with my Nissan Leaf 2018 TEKNA. Everything seems to work fine and fast! I'm confident that this works much better than the Nissan app, as I've been using the other non-official component as well. 👍 |
@MartinHjelmare apologies for the delay - I've linked the new docs PR to this PR. |
|
Slight correction in the docs: 2015s have CarWings too. The cut-off was the 16 plate 24kwh and the 65 plate 30kwh I believe. The easiest way to identify is that Nissan Connect's T&C buttons are orange and blue, CarWings they're both blue. Or just look for anything saying "CarWings" in Settings. |
|
Please open an issue in or make a PR to the docs repo. |
Description:
Follow-up to pull request #19786 for Nissan Leaf integration to try to fix issues identified by @MartinHjelmare.
Improvements remaining to be made (at least!):
how to implement start charging. Switch (status quo), scene + sensor, or service + sensor.iconsremove time.sleep(x)**Pull request for home-assistant.io with documentation has already been merged: home-assistant/home-assistant.io#8073 but needs to be updated to include new service.
Example entry for
configuration.yaml:Two new services exposed:
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: