Add nissan_leaf.start_charge service and doc fixes.#8801
Merged
Conversation
ghost
added
the
| required: false | ||
| type: boolean | ||
| scan_interval: | ||
| update_interval: |
Member
There was a problem hiding this comment.
It would be good to change this in the source to scan_interval. We're in the process of moving all other similar terms over to that name.
Member
There was a problem hiding this comment.
That would require an update to the component. While I do agree with you @MartinHjelmare, this update reflects the code changes in the parent PR. Considering that, I would suggest merging this in for now?
Member
There was a problem hiding this comment.
Yes @frenck! 👍 My comment was more a for the future thing. Sorry about not being clear.
klaasnicolaas
added
next
MartinHjelmare
approved these changes
Mar 4, 2019
balloob
added
the
cherry-picked
balloob
pushed a commit
that referenced
this pull request
Mar 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Additional docs for the new Nissan leaf component, as part of PR home-assistant/core#21145. Should be included in the 0.89 release.
Pull request in home-assistant (if applicable): home-assistant/core#21145
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.