Skip to content

Initial documentation for nissan_leaf#8073

Merged
fabaff merged 8 commits into
home-assistant:nextfrom
filcole:nissanleaf
Feb 15, 2019
Merged

Initial documentation for nissan_leaf#8073
fabaff merged 8 commits into
home-assistant:nextfrom
filcole:nissanleaf

Conversation

@filcole
Copy link
Copy Markdown
Contributor

@filcole filcole commented Jan 6, 2019

Description:

Pull request in home-assistant: home-assistant/core#19786

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Jan 6, 2019
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Jan 21, 2019
DubhAd
DubhAd previously requested changes Feb 2, 2019
Comment thread source/_components/nissan_leaf.markdown Outdated
Comment thread source/_components/nissan_leaf.markdown Outdated
Comment thread source/_components/nissan_leaf.markdown Outdated
Comment thread source/_components/nissan_leaf.markdown Outdated
Comment thread source/_components/nissan_leaf.markdown Outdated
Comment thread source/_components/nissan_leaf.markdown Outdated
Comment thread source/_components/nissan_leaf.markdown Outdated
klaasnicolaas
klaasnicolaas previously approved these changes Feb 11, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ Pherhaps that the ha_release must be updated before merged.

@klaasnicolaas klaasnicolaas added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Feb 14, 2019
fabaff
fabaff previously approved these changes Feb 15, 2019
@fabaff fabaff dismissed DubhAd’s stale review February 15, 2019 12:07

Comments addressed

@fabaff fabaff merged commit e9344e1 into home-assistant:next Feb 15, 2019
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Feb 15, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

Release 0.88 or 0.89?

Comment thread source/_components/nissan_leaf.markdown
@filcole filcole mentioned this pull request Feb 17, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants