Add mychevy optional country parameter#19727
Merged
Merged
Conversation
homeassistant
added
cla-signed
integration: mychevy
small-pr
ghost
assigned
pvizeli
reviewed
Jan 2, 2019
| DOMAIN: vol.Schema({ | ||
| vol.Required(CONF_USERNAME): cv.string, | ||
| vol.Required(CONF_PASSWORD): cv.string, | ||
| vol.Optional(CONF_COUNTRY, default="us"): cv.string |
Member
There was a problem hiding this comment.
vol.All(cv.string, vol.In(['us', 'ca']))?
Contributor
Author
There was a problem hiding this comment.
Thanks! I was wondering how to do that.
mychevy 1.2.0 provides the ability to work in canada as well as the us (there are different service urls for each region). This creates a new config option to enable it.
Member
|
Could not find a matching documentation PR in our documentation repository. Adding |
2 tasks
Contributor
Author
|
Docs are now added |
pvizeli
approved these changes
Jan 3, 2019
MartinHjelmare
changed the title
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* Add optional country parameter mychevy 1.2.0 provides the ability to work in canada as well as the us (there are different service urls for each region). This creates a new config option to enable it. * Update mychevy.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mychevy 1.2.0 provides the ability to work in canada as well as the us
(there are different service urls for each region). This creates a new
config option to enable it.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: