Skip to content

add country support to mychevy#8030

Merged
cgarwood merged 2 commits into
home-assistant:nextfrom
sdague:mychevy_next
Jan 4, 2019
Merged

add country support to mychevy#8030
cgarwood merged 2 commits into
home-assistant:nextfrom
sdague:mychevy_next

Conversation

@sdague
Copy link
Copy Markdown
Contributor

@sdague sdague commented Jan 3, 2019

Description:

This adds support for the new country parameter for the mychevy component so it can work for folks in canada.

Pull request in home-assistant (if applicable): home-assistant/core#19727

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost assigned sdague Jan 3, 2019
@ghost ghost added the ready-for-review This PR needs to be reviewed label Jan 3, 2019
Comment thread source/_components/mychevy.markdown Outdated
required: true
type: string
country:
description: Which country's servers to contact. Defaults to 'us', also supports 'ca'.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the default in a variable
So: "default: us"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgarwood cgarwood merged commit 9d5e147 into home-assistant:next Jan 4, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jan 4, 2019
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants