Rename air pollutants to air quality#19448
Merged
Merged
Conversation
ghost
added
the
2 tasks
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Have we released any of the air pollutants platforms yet? If not, this is not a breaking change.
Contributor
Author
|
No, moved them manually.
It's not a breaking change, air pollutants will be on the next release.
…On Wed, Dec 19, 2018, 10:32 Martin Hjelmare ***@***.*** wrote:
***@***.**** commented on this pull request.
Have we released any of the air pollutants platforms yet? If not, this is
not a breaking change.
------------------------------
In tests/components/air_quality/__init__.py
<#19448 (comment)>
:
> @@ -0,0 +1 @@
+"""The tests for Air Quality platforms."""
Was the renamed modules moved with git mv one module per commit?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19448 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AH2OZ_SWz3vgMLd_Vnhk3CzX8obWutXxks5u6gewgaJpZM4ZZs1C>
.
|
eliseomartelli
force-pushed
the
rename_air_quality
branch
from
c072a1c to
9cd278e
Compare
Contributor
Author
|
The last force push should fix your concerns! @MartinHjelmare |
Member
Member
|
Let's make sure we have a decision in the architecture issue before we merge this. |
Contributor
Author
|
ok! @MartinHjelmare I'm setting it as a WIP |
eliseomartelli
changed the title
eliseomartelli
force-pushed
the
rename_air_quality
branch
from
e542897 to
b2034a7
Compare
Contributor
Author
|
Let's see if it works now :) @MartinHjelmare |
eliseomartelli
changed the title
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
The test module move worked now, but not the package, but that's ok I think.
|
|
||
| For more details about this platform, please refer to the documentation at | ||
| https://home-assistant.io/components/air_pollutants_opensensemap/ | ||
| https://home-assistant.io/components/air_quality_opensensemap/ |
Member
There was a problem hiding this comment.
The url is wrong. Look at eg a sensor platform to see the correct path format.
| @@ -1,4 +1,4 @@ | |||
| """The tests for the Air Pollutants component.""" | |||
| """The tests for the Air Quality component.""" | |||
| from homeassistant.components.air_pollutants import ( | |||
Member
There was a problem hiding this comment.
This module also needs updating.
balloob
reviewed
Dec 20, 2018
Member
|
Should we merge this first or the other platforms that are going under air pollutants? If we merge the others first we would need to convert them too here. |
8 tasks
Member
|
We should put this in beta I think ? |
Contributor
Author
|
@balloob yep, should be in beta :) |
2 tasks
balloob
pushed a commit
that referenced
this pull request
Jan 9, 2019
* mv component folder * moved in airquality * changed names in files * renamed test init * renamed test air quality * renamed in tests * renamed coverage * fixed naming * corrected attr names * changed attr names
Merged
rymsha
pushed a commit
to rymsha/home-assistant
that referenced
this pull request
Jan 12, 2019
* mv component folder * moved in airquality * changed names in files * renamed test init * renamed test air quality * renamed in tests * renamed coverage * fixed naming * corrected attr names * changed attr names
rymsha
pushed a commit
to rymsha/home-assistant
that referenced
this pull request
Jan 12, 2019
* mv component folder * moved in airquality * changed names in files * renamed test init * renamed test air quality * renamed in tests * renamed coverage * fixed naming * corrected attr names * changed attr names
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* mv component folder * moved in airquality * changed names in files * renamed test init * renamed test air quality * renamed in tests * renamed coverage * fixed naming * corrected attr names * changed attr names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rename air pollutants to air quality
Related issue (if applicable): fixes home-assistant/architecture#122
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7901
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: