Skip to content

Docs for nilu air_quality platform#7993

Merged
fabaff merged 5 commits into
home-assistant:nextfrom
hfurubotten:air-pollutants-nilu
Jan 27, 2019
Merged

Docs for nilu air_quality platform#7993
fabaff merged 5 commits into
home-assistant:nextfrom
hfurubotten:air-pollutants-nilu

Conversation

@hfurubotten
Copy link
Copy Markdown
Contributor

@hfurubotten hfurubotten commented Dec 30, 2018

Description:

Documentation for new platform in the air_pollutants platform. Shows data from the governmental air research institutes sensor stations within Norway.

Pull request in home-assistant (if applicable): home-assistant/core#19674

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Dec 30, 2018
@hfurubotten hfurubotten changed the title WIP: Docs for nilu air_pollution platform Docs for nilu air_pollution platform Dec 30, 2018
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Dec 31, 2018
@ghost ghost assigned frenck Dec 31, 2018
frenck
frenck previously approved these changes Dec 31, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck removed their assignment Dec 31, 2018
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Dec 31, 2018
@hfurubotten
Copy link
Copy Markdown
Contributor Author

hfurubotten commented Jan 8, 2019

I'm guessing that I should rename the documentation file from air_pollutants.nilu.markdown to air_quality.nilu.markdown since the component had the name change in the backend?

However can't see that the other platforms have gotten the name change after home-assistant/core#19448 tho. Should I open an issue/PR on this as well? Should probably get the name change before the beta period is done..

Edit: I see the update is made and I will do the same.

@hfurubotten hfurubotten changed the title Docs for nilu air_pollution platform Docs for nilu air_quality platform Jan 15, 2019
@frenck frenck added ready-for-review This PR needs to be reviewed and removed awaits-parent Awaits the merge of an parent PR labels Jan 22, 2019
@ghost ghost assigned fabaff Jan 27, 2019
@fabaff fabaff merged commit b267b78 into home-assistant:next Jan 27, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Jan 27, 2019
@hfurubotten hfurubotten deleted the air-pollutants-nilu branch January 28, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants