Skip to content

Add package data attribute to 17track.net summary sensors #19213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
Dec 12, 2018
Merged

Add package data attribute to 17track.net summary sensors #19213

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
696c819
17track.net: Add package data attribute to summary sensors
bachya Dec 12, 2018
3be9fc7
Member comments
bachya Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions homeassistant/components/sensor/seventeentrack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@
_LOGGER = logging.getLogger(__name__)

ATTR_DESTINATION_COUNTRY = 'destination_country'
ATTR_FRIENDLY_NAME = 'friendly_name'
ATTR_INFO_TEXT = 'info_text'
ATTR_ORIGIN_COUNTRY = 'origin_country'
ATTR_PACKAGES = 'packages'
ATTR_PACKAGE_TYPE = 'package_type'
ATTR_STATUS = 'status'
ATTR_TRACKING_INFO_LANGUAGE = 'tracking_info_language'
ATTR_TRACKING_NUMBER = 'tracking_number'

Expand Down Expand Up @@ -117,7 +120,7 @@ def icon(self):
@property
def name(self):
"""Return the name."""
return '17track Packages {0}'.format(self._status)
return 'Seventeentrack Packages {0}'.format(self._status)

@property
def state(self):
Expand All @@ -139,6 +142,21 @@ async def async_update(self):
"""Update the sensor."""
await self._data.async_update()

package_data = []
for package in self._data.packages:
if package.status != self._status:
continue

package_data.append({
ATTR_FRIENDLY_NAME: package.friendly_name,
ATTR_INFO_TEXT: package.info_text,
ATTR_STATUS: package.status,
ATTR_TRACKING_NUMBER: package.tracking_number,
})

if package_data:
self._attrs[ATTR_PACKAGES] = package_data

self._state = self._data.summary.get(self._status)


Expand Down Expand Up @@ -186,7 +204,7 @@ def name(self):
name = self._friendly_name
if not name:
name = self._tracking_number
return '17track Package: {0}'.format(name)
return 'Seventeentrack Package: {0}'.format(name)

@property
def state(self):
Expand Down