Skip to content

Small refactoring of MQTT binary_sensor#18674

Merged
balloob merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_binary_sensor_refactor
Nov 25, 2018
Merged

Small refactoring of MQTT binary_sensor#18674
balloob merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_binary_sensor_refactor

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

Description:

Small refactoring of MQTT binary_sensor as proposed in #18174:

  • Just store config instead of every variable since the configuration values are just copied.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@emontnemery
Copy link
Copy Markdown
Contributor Author

@balloob I think this is what you had in mind in #18174?

@balloob balloob merged commit d290ce3 into home-assistant:dev Nov 25, 2018
@ghost ghost removed the in progress label Nov 25, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 25, 2018

Yes. Looks so much cleaner I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants