Skip to content

Small refactoring of MQTT climate#18814

Merged
balloob merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_climate_refactor
Dec 2, 2018
Merged

Small refactoring of MQTT climate#18814
balloob merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_climate_refactor

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Nov 29, 2018

Description:

Small refactoring of MQTT climate as proposed in #18174:

  • Just store config instead of every variable since the configuration values are just copied.

(Follow-up to #18674)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned emontnemery Nov 29, 2018
@ghost ghost added the in progress label Nov 29, 2018
@balloob balloob merged commit ce218b1 into home-assistant:dev Dec 2, 2018
@ghost ghost removed the in progress label Dec 2, 2018
def _setup_from_config(self, config):
"""(Re)Setup the entity."""
self._name = config.get(CONF_NAME)
# self._name = config.get(CONF_NAME)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry about that! I'll fix that, thanks for noticing.

@emontnemery emontnemery mentioned this pull request Dec 2, 2018
3 tasks
@emontnemery emontnemery deleted the mqtt_climate_refactor branch December 2, 2018 16:28
@balloob balloob mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants