Skip to content

Small refactoring of MQTT fan#18851

Merged
Danielhiversen merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_fan_refactor
Dec 2, 2018
Merged

Small refactoring of MQTT fan#18851
Danielhiversen merged 1 commit intohome-assistant:devfrom
emontnemery:mqtt_fan_refactor

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Nov 30, 2018

Description:

Small refactoring of MQTT fan as proposed in #18174:

  • Just store config instead of every variable since the configuration values are just copied.

(Follow-up to #18674)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned emontnemery Nov 30, 2018
@ghost ghost added the in progress label Nov 30, 2018
@Danielhiversen Danielhiversen merged commit b063547 into home-assistant:dev Dec 2, 2018
@ghost ghost removed the in progress label Dec 2, 2018
@emontnemery emontnemery deleted the mqtt_fan_refactor branch December 2, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emontnemery emontnemery

Labels

cla-signed integration: mqtt small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emontnemery @Danielhiversen @homeassistant