Skip to content

Add ness alarm control panel using nessclient#18463

Merged
MartinHjelmare merged 12 commits into
home-assistant:devfrom
nickw444:nwhyte/ness-alarm
Jan 1, 2019
Merged

Add ness alarm control panel using nessclient#18463
MartinHjelmare merged 12 commits into
home-assistant:devfrom
nickw444:nwhyte/ness-alarm

Conversation

@nickw444
Copy link
Copy Markdown
Contributor

@nickw444 nickw444 commented Nov 14, 2018

Description:

Adds new ness D8x/D16x alarm platform using nessclient client library. Underlying library takes advantage of the Ness D8x/D16x ASCII protocol

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7630

Example entry for configuration.yaml (if applicable):

ness_alarm:
  host: alarm.local
  port: 2401
  zones:
    - name: Garage
      id: 1
    - name: Storeroom
      id: 2
    - name: Kitchen
      id: 3
    - name: Front Entrance
      id: 4

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/binary_sensor/ness_alarm.py Outdated
Comment thread homeassistant/components/binary_sensor/ness_alarm.py Outdated
Comment thread homeassistant/components/binary_sensor/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/binary_sensor/test_ness_alarm.py Outdated
Comment thread tests/components/binary_sensor/test_ness_alarm.py Outdated
Comment thread tests/components/binary_sensor/test_ness_alarm.py Outdated
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
@nickw444 nickw444 changed the title WIP: Add ness alarm control panel using pyness232 Add ness alarm control panel using pyness232 Nov 25, 2018
@nickw444
Copy link
Copy Markdown
Contributor Author

nickw444 commented Nov 30, 2018

Hi @frenck this pull request is ready for review. It seems the labels and wip build status hasn’t been updated since I renamed it and finalised the code.

Cheers 🙂

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good. Tests should take a different approach though, and be written more like integration tests which is our standard.

Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

To remove WIP label, rebase and reword the commit messages that contain WIP.

Comment thread homeassistant/components/alarm_control_panel/ness_alarm.py
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
@nickw444 nickw444 changed the title Add ness alarm control panel using pyness232 Add ness alarm control panel using nessclient Dec 27, 2018
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

Please don't squash commits after review has started to make it easier for readers to track changes.

Comment thread homeassistant/components/binary_sensor/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread homeassistant/components/ness_alarm.py Outdated
Comment thread tests/components/alarm_control_panel/test_ness_alarm.py Outdated
Comment thread tests/components/binary_sensor/test_ness_alarm.py Outdated
Comment thread tests/components/binary_sensor/test_ness_alarm.py Outdated
Comment thread tests/components/test_ness_alarm.py Outdated
Comment thread .coveragerc Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 5aa2bd8 into home-assistant:dev Jan 1, 2019
@ghost ghost removed the in progress label Jan 1, 2019
@balloob balloob mentioned this pull request Jan 10, 2019
kellerza pushed a commit to kellerza/ha-core that referenced this pull request Jan 18, 2019
* Add ness alarm control panel using nessclient

* indenting

* .

* Remove availability functionality, will improve and add back in another PR

* Use call_count

* lint

* lint

* Review changes

* Lint

* Bump nessclient to 0.9.8

* Bump nessclient to 0.9.9

* Remove from .coveragerc
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
* Add ness alarm control panel using nessclient

* indenting

* .

* Remove availability functionality, will improve and add back in another PR

* Use call_count

* lint

* lint

* Review changes

* Lint

* Bump nessclient to 0.9.8

* Bump nessclient to 0.9.9

* Remove from .coveragerc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants