Add ness alarm control panel using nessclient#18463
Merged
Merged
Conversation
houndci-bot
reviewed
Nov 14, 2018
bd2b620 to
ce9ac8b
Compare
houndci-bot
reviewed
Nov 24, 2018
houndci-bot
reviewed
Nov 24, 2018
houndci-bot
reviewed
Nov 24, 2018
2 tasks
Contributor
Author
|
Hi @frenck this pull request is ready for review. It seems the labels and wip build status hasn’t been updated since I renamed it and finalised the code. Cheers 🙂 |
MartinHjelmare
requested changes
Dec 9, 2018
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
In general looks good. Tests should take a different approach though, and be written more like integration tests which is our standard.
Member
|
To remove WIP label, rebase and reword the commit messages that contain WIP. |
99bfb6e to
6736cc9
Compare
houndci-bot
reviewed
Dec 24, 2018
houndci-bot
reviewed
Dec 27, 2018
faf6ea5 to
30243bc
Compare
houndci-bot
reviewed
Dec 28, 2018
Member
|
Please don't squash commits after review has started to make it easier for readers to track changes. |
houndci-bot
reviewed
Dec 31, 2018
7958411 to
a6933ff
Compare
Merged
kellerza
pushed a commit
to kellerza/ha-core
that referenced
this pull request
Jan 18, 2019
* Add ness alarm control panel using nessclient * indenting * . * Remove availability functionality, will improve and add back in another PR * Use call_count * lint * lint * Review changes * Lint * Bump nessclient to 0.9.8 * Bump nessclient to 0.9.9 * Remove from .coveragerc
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* Add ness alarm control panel using nessclient * indenting * . * Remove availability functionality, will improve and add back in another PR * Use call_count * lint * lint * Review changes * Lint * Bump nessclient to 0.9.8 * Bump nessclient to 0.9.9 * Remove from .coveragerc
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds new ness D8x/D16x alarm platform using
nessclientclient library. Underlying library takes advantage of the Ness D8x/D16x ASCII protocolRelated issue (if applicable): fixes #Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7630
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: