Fix ness alarm armed_home state appearing as disarmed/armed_away#94351
Merged
emontnemery merged 4 commits intoAug 16, 2023
Conversation
58c9a7f to
41ba047
Compare
41ba047 to
07017b3
Compare
de2fafb to
3df41f5
Compare
45a8d3b to
1e1c8ce
Compare
1e1c8ce to
878207e
Compare
emontnemery
requested changes
Jun 28, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
emontnemery
approved these changes
Jun 28, 2023
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
LGTM, thanks @nickw444 👍
emontnemery
requested changes
Jun 28, 2023
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
Sorry about the mess @nickw444, I didn't notice you on purpose don't have a constant map between enum and Home Assistant states. Can you explain why you do that?
emontnemery
reviewed
Jun 28, 2023
803480c to
4905ddf
Compare
This reverts commit b9cca8e92bcb382abe364381a8cb1674c32d1d2a.
4905ddf to
837ff5a
Compare
emontnemery
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes the alarm panel incorrectly displaying as
armed_awaywhen it has been put into another state (e.g.armed_home)The dependency (
nessclient) has had changes to fix this issue: https://github.com/nickw444/nessclient/releases/tag/1.0.0Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
Documentation added/updated for www.home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: