Skip to content

Fix ness alarm armed_home state appearing as disarmed/armed_away#94351

Merged
emontnemery merged 4 commits into
home-assistant:devfrom
nickw444:nwhyte/nessclient-arm-home
Aug 16, 2023
Merged

Fix ness alarm armed_home state appearing as disarmed/armed_away#94351
emontnemery merged 4 commits into
home-assistant:devfrom
nickw444:nwhyte/nessclient-arm-home

Conversation

@nickw444
Copy link
Copy Markdown
Contributor

@nickw444 nickw444 commented Jun 9, 2023

Proposed change

Fixes the alarm panel incorrectly displaying as armed_away when it has been put into another state (e.g. armed_home)

The dependency (nessclient) has had changes to fix this issue: https://github.com/nickw444/nessclient/releases/tag/1.0.0

Before After
2023-06-15 20 31 55 2023-06-15 20 30 09

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch from 58c9a7f to 41ba047 Compare June 9, 2023 13:11
@nickw444 nickw444 changed the title Fix nessclient arm home appearing as arm away Fix nessclient arm home appearing as disarmed Jun 13, 2023
@nickw444 nickw444 changed the title Fix nessclient arm home appearing as disarmed Fix ness alarm arm home appearing as disarmed Jun 13, 2023
@nickw444 nickw444 changed the title Fix ness alarm arm home appearing as disarmed Fix ness alarm arm_home state appearing as disarmed Jun 13, 2023
@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch from 41ba047 to 07017b3 Compare June 15, 2023 10:31
@nickw444 nickw444 changed the title Fix ness alarm arm_home state appearing as disarmed Fix ness alarm arm_home state appearing as disarmed/armed_away Jun 15, 2023
@nickw444 nickw444 changed the title Fix ness alarm arm_home state appearing as disarmed/armed_away Fix ness alarm armed_home state appearing as disarmed/armed_away Jun 15, 2023
@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch 2 times, most recently from de2fafb to 3df41f5 Compare June 15, 2023 10:56
@nickw444 nickw444 marked this pull request as ready for review June 15, 2023 21:49
@nickw444 nickw444 marked this pull request as draft June 15, 2023 21:49
@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch from 45a8d3b to 1e1c8ce Compare June 16, 2023 10:16
@nickw444 nickw444 marked this pull request as ready for review June 16, 2023 11:54
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch from 1e1c8ce to 878207e Compare June 26, 2023 01:33
Comment thread homeassistant/components/ness_alarm/alarm_control_panel.py Outdated
Comment thread homeassistant/components/ness_alarm/alarm_control_panel.py Outdated
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft June 28, 2023 06:49
@emontnemery emontnemery marked this pull request as ready for review June 28, 2023 06:57
@home-assistant home-assistant Bot requested a review from emontnemery June 28, 2023 06:57
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nickw444 👍

@emontnemery emontnemery added this to the 2023.7.0b0 milestone Jun 28, 2023
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the mess @nickw444, I didn't notice you on purpose don't have a constant map between enum and Home Assistant states. Can you explain why you do that?

@home-assistant home-assistant Bot marked this pull request as draft June 28, 2023 08:07
Comment thread tests/components/ness_alarm/test_init.py Outdated
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2023
@emontnemery emontnemery removed this from the 2023.7.0b0 milestone Jun 28, 2023
@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch from 803480c to 4905ddf Compare August 15, 2023 22:54
@nickw444 nickw444 marked this pull request as ready for review August 16, 2023 00:55
@home-assistant home-assistant Bot requested a review from emontnemery August 16, 2023 00:55
@nickw444 nickw444 force-pushed the nwhyte/nessclient-arm-home branch from 4905ddf to 837ff5a Compare August 16, 2023 00:56
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2023.8.3 milestone Aug 16, 2023
@emontnemery emontnemery merged commit 2c48f0e into home-assistant:dev Aug 16, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ness_alarm: status does not display correctly for Home Mode

4 participants