Add option to manually specify device detection method#17852
Merged
fabaff merged 2 commits intohome-assistant:devfrom Nov 3, 2018
Merged
Add option to manually specify device detection method#17852fabaff merged 2 commits intohome-assistant:devfrom
fabaff merged 2 commits intohome-assistant:devfrom
Conversation
Contributor
|
Hi @heytensai, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
houndci-bot
reviewed
Oct 27, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
2 tasks
wolph
added a commit
to wolph/home-assistant
that referenced
this pull request
Nov 14, 2018
Pull request home-assistant#17852 accidently made the `method` setting required.
3 tasks
MartinHjelmare
pushed a commit
that referenced
this pull request
Nov 14, 2018
Pull request #17852 accidently made the `method` setting required.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Mikrotik module automatically detects whether to use wireless, capsman, or dhcp for device detection. If a Mikrotik router has wireless but the use prefers to use dhcp, this new option allows the user to force a specific method.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7145
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: