Skip to content

Add option to manually specify device detection method#17852

Merged
fabaff merged 2 commits intohome-assistant:devfrom
heytensai:mikrotik-method
Nov 3, 2018
Merged

Add option to manually specify device detection method#17852
fabaff merged 2 commits intohome-assistant:devfrom
heytensai:mikrotik-method

Conversation

@heytensai
Copy link
Copy Markdown
Contributor

@heytensai heytensai commented Oct 27, 2018

Description:

Mikrotik module automatically detects whether to use wireless, capsman, or dhcp for device detection. If a Mikrotik router has wireless but the use prefers to use dhcp, this new option allows the user to force a specific method.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7145

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: mikrotik
    host: IP_ADDRESS
    username: ADMIN_USERNAME
    password: ADMIN_PASSWORD
    method: ip

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @heytensai,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@ghost ghost assigned fabaff Nov 2, 2018
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit 155df91 into home-assistant:dev Nov 3, 2018
@ghost ghost removed the in progress label Nov 3, 2018
wolph added a commit to wolph/home-assistant that referenced this pull request Nov 14, 2018
Pull request home-assistant#17852 accidently made the `method` setting required.
MartinHjelmare pushed a commit that referenced this pull request Nov 14, 2018
Pull request #17852 accidently made the `method` setting required.
@balloob balloob mentioned this pull request Nov 29, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants