Skip to content

Add option to manually specify device detection method#7145

Merged
frenck merged 2 commits intohome-assistant:nextfrom
heytensai:mikrotik-method
Nov 11, 2018
Merged

Add option to manually specify device detection method#7145
frenck merged 2 commits intohome-assistant:nextfrom
heytensai:mikrotik-method

Conversation

@heytensai
Copy link
Copy Markdown
Contributor

@heytensai heytensai commented Oct 27, 2018

Description:

Add new option to mikrotik device detection which allows the user to specify how to scan router for devices.

Pull request in home-assistant (if applicable): home-assistant/core#17852

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Oct 27, 2018
@fabaff fabaff added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Oct 28, 2018
@ghost ghost assigned frenck Oct 29, 2018
@ghost ghost added ready-for-review This PR needs to be reviewed and removed to-do labels Oct 29, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! next This PR goes into the next branch has-parent This PR has a parent PR in another repo awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Oct 29, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck removed their assignment Oct 29, 2018
@frenck frenck added the parent-merged The parent PR has been merged already label Nov 11, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Nov 11, 2018

Thanks, @heytensai! 🎉

@frenck frenck merged commit e6f4106 into home-assistant:next Nov 11, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants