Skip to content

Make mikrotik method setting optional as intended#18454

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
wolph:patch-1
Nov 14, 2018
Merged

Make mikrotik method setting optional as intended#18454
MartinHjelmare merged 1 commit intohome-assistant:devfrom
wolph:patch-1

Conversation

@wolph
Copy link
Copy Markdown
Contributor

@wolph wolph commented Nov 14, 2018

Pull request #17852 accidently made the method setting required.

Description:

Pull request #17852 accidently made the method setting required while it was intended to be optional. This tiny change fixes that :)

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable):

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: mikrotik
    host: IP_ADDRESS
    username: ADMIN_USERNAME
    password: ADMIN_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

Pull request home-assistant#17852 accidently made the `method` setting required.
@ghost ghost added the in progress label Nov 14, 2018
@MartinHjelmare MartinHjelmare changed the title Made method setting optional as intended Make mikrotik method setting optional as intended Nov 14, 2018
@MartinHjelmare MartinHjelmare merged commit 80e616c into home-assistant:dev Nov 14, 2018
@ghost ghost removed the in progress label Nov 14, 2018
@balloob balloob mentioned this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants