Make mikrotik method setting optional as intended#18454
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Nov 14, 2018
Merged
Make mikrotik method setting optional as intended#18454MartinHjelmare merged 1 commit intohome-assistant:devfrom
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Conversation
Pull request home-assistant#17852 accidently made the `method` setting required.
method setting optional as intended
MartinHjelmare
approved these changes
Nov 14, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #17852 accidently made the
methodsetting required.Description:
Pull request #17852 accidently made the
methodsetting required while it was intended to be optional. This tiny change fixes that :)Related issue (if applicable):
Pull request in home-assistant.io with documentation (if applicable):
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass