Move FFmpeg 'run_test' configuration from platform to components#17769
Move FFmpeg 'run_test' configuration from platform to components#17769jjlawren wants to merge 4 commits intohome-assistant:devfrom
Conversation
|
I'm currently not sure if the current handling not better and we need to update the documentation. The Idea was that you can add ffmpeg sensors/camera and it will test that on startup, that makes the startup slower but for "normal" users it make the config save. If the user is sure that he doesn't need this, he can disable it on component global config with: ffmpeg:
run_test: falseNow, both work and not. If you disable it global, the platform settings don't work. That makes it a bit weird. Why are the old settings not working for you? |
|
My specific use case is that I have multiple ffmpeg-based entities, where some inputs are always available and others which turn on/off. The ones that can turn on/off are sometimes not providing feeds when HA is started and it fails to create the entities. On the other hand, I'd like it to validate the inputs which I expect to always be available. Perhaps the docs (in the components) could reflect that a global override can be set in the |
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
|
I've taken your suggestion and gone all-in on configuring tests on the individual components and removed the global |
|
@pvizeli can you comment on the latest change? I’ll need to fix the tests but want to confirm the new direction is agreeable first. |
|
Closing in favor of #18131. |
Description:
Related issue (if applicable): fixes #17495
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7064
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: