Remove FFmpeg input tests#18131
Merged
balloob merged 10 commits intohome-assistant:devfrom Nov 3, 2018
Merged
Conversation
homeassistant
added
cla-signed
integration: ffmpeg
platform: binary_sensor.ffmpeg_motion
small-pr
2 tasks
balloob
reviewed
Nov 2, 2018
balloob
approved these changes
Nov 3, 2018
balloob
pushed a commit
that referenced
this pull request
Nov 3, 2018
* Remove FFmpeg input tests * Not needed here * Removing tests for removed functionality * Minor lint * Fix tests to reflect removed config option * Remove async service registration by request * More lint * Unused imports * Make it a non-breaking change * Update ffmpeg.py
Merged
4 tasks
3 tasks
ghost
added
integration: ffmpeg_noise
integration: ffmpeg_motion
and removed
platform: binary_sensor.ffmpeg_motion
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Removes FFmpeg input validation tests on startup as it provides no obvious benefit.
Related issue (if applicable): fixes #17684, fixes #17934
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7342
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: