Skip to content

Add 'run_test' configs to skip ffmpeg input test on startup#7064

Closed
jjlawren wants to merge 4 commits intohome-assistant:nextfrom
jjlawren:ffmpeg_allow_skip_test
Closed

Add 'run_test' configs to skip ffmpeg input test on startup#7064
jjlawren wants to merge 4 commits intohome-assistant:nextfrom
jjlawren:ffmpeg_allow_skip_test

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Oct 24, 2018

Description:

Pull request in home-assistant (if applicable): home-assistant/core#17769

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Oct 24, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration in-progress This PR/Issue is currently being worked on next This PR goes into the next branch has-parent This PR has a parent PR in another repo Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! and removed to-do labels Oct 25, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 25, 2018

Really small change needed there @jjlawren!
Could you take a look? 👍

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Oct 25, 2018
frenck
frenck previously approved these changes Oct 25, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@jjlawren
Copy link
Copy Markdown
Contributor Author

Changed some functionality in the parent PR to address design concerns, updated docs to match.

@frenck frenck added ready-for-review This PR needs to be reviewed and removed awaits-parent Awaits the merge of an parent PR labels Nov 1, 2018
@jjlawren
Copy link
Copy Markdown
Contributor Author

jjlawren commented Nov 3, 2018

Closing in favor of #7342.

@jjlawren jjlawren closed this Nov 3, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants