Fix tilt controls for TiltOnlyVenetianBlind in Overkiz by iMicknl · Pull Request #170055 · home-assistant/core

iMicknl · 2026-05-07T20:27:26Z

Proposed change

The #141330 refactor caused unintended side effects for the TiltOnlyVenetianBlind device. This PR fixes the tilt controls, add a fixture for this device and adds a new test to also test the commands with parameters.

Fix verified by @bramkragten today.

Fixes #169999.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

The TILT_ONLY_VENETIAN_BLIND widget was missing open/close/stop command mappings, causing the cover to only expose tilt controls. Additionally, tiltPositive and tiltNegative require two parameters and should not have a delay appended on RTS devices. Fixes home-assistant#169999

Move the TiltOnlyVenetianBlind device into the existing RTS fixture and replace the monolithic test with a parametrized test focused on verifying the correct command and parameters are sent for each service.

Copilot

Pull request overview

Fixes Overkiz TiltOnlyVenetianBlind command handling/regression introduced by the cover entity-description refactor, ensuring tilt commands are sent with the correct parameters for RTS devices.

Changes:

Update the TILT_ONLY_VENETIAN_BLIND cover description to use open/close/stop for full movement and tiltPositive/tiltNegative with the correct command arguments.
Prevent RTS “duration=0” parameter injection for tiltPositive/tiltNegative to avoid sending an extra unintended parameter.
Add a new RTS TiltOnlyVenetianBlind fixture device plus a parameterized test and snapshot updates to validate the exact command parameters sent.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
homeassistant/components/overkiz/cover.py	Adds explicit open/close/stop commands and correct tilt command args for TiltOnlyVenetianBlind.
homeassistant/components/overkiz/executor.py	Excludes `TILT_POSITIVE`/`TILT_NEGATIVE` from RTS duration parameter injection.
tests/components/overkiz/fixtures/setup/cloud_somfy_connexoon_rts_asia.json	Adds a TiltOnlyVenetianBlind RTS device to the fixture setup.
tests/components/overkiz/test_cover.py	Adds a parameterized test validating command names and parameters for the new fixture device.
tests/components/overkiz/snapshots/test_cover.ambr	Updates snapshots to include the newly added cover entity from the fixture.

Remove the separate test_cover_command_parameters function and add its parametrize entries into test_cover_service_actions with a new parameters column. Fix fixture to remove non-existent state for RTS device and update expected states accordingly.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

…y-venetian-blind-169999

iMicknl · 2026-05-07T21:42:03Z

Failed CI is not related to this branch/changes..

…y-venetian-blind-169999

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…venetian-blind-169999 # Conflicts: # tests/components/overkiz/test_cover.py

…com:iMicknl/home-assistant-core into fix/overkiz-tilt-only-venetian-blind-169999

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

…ot test

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…2026.5.0 → 2026.5.1) (#411) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.5.0` → `2026.5.1` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary> ### [`v2026.5.1`](https://github.com/home-assistant/core/releases/tag/2026.5.1) [Compare Source](home-assistant/core@2026.5.0...2026.5.1) - Added wfsens as a occupancy source in wiz ([@th3spis] - [#166799]) ([wiz docs]) - Fix WiZ Light config flow timeout by properly closing UDP connections ([@robwasripped] - [#168456]) ([wiz docs]) - Fix IntelliFire setup recovery ([@jeeftor] - [#169739]) ([intellifire docs]) - Fix hassio auth IndexError on Supervisor Unix socket requests ([@agners] - [#169911]) ([hassio docs]) - Update gardena ble to 2.8.1 ([@elupus] - [#169914]) ([gardena\_bluetooth docs][gardena_bluetooth docs]) ([husqvarna\_automower\_ble docs][husqvarna_automower_ble docs]) (dependency) - Bump serialx to 1.7.1 ([@puddly] - [#169928]) ([serial docs]) ([acer\_projector docs][acer_projector docs]) ([usb docs]) (dependency) - Bump holidays to 0.96 ([@gjohansson-ST] - [#169939]) ([workday docs]) ([holiday docs]) (dependency) - Add support for options to todo triggers ([@emontnemery] - [#169947]) ([todo docs]) - Bump pyTibber to 0.37.5 ([@Danielhiversen] - [#169981]) ([tibber docs]) (dependency) - Bump python-duco-client to 0.4.0 ([@ronaldvdmeer] - [#169776]) ([duco docs]) (dependency) - Bump python-duco-client to 0.4.1 ([@ronaldvdmeer] - [#169991]) ([duco docs]) (dependency) - Proper handling of malformed data during FRITZ!Box Tools setup ([@mib1185] - [#170030]) ([fritz docs]) - Fix websocket certificate verification Bump axis to v70 ([@Kane610] - [#170038]) ([axis docs]) (dependency) - Fix `is_closed` state for DynamicGarageDoor in Overkiz ([@iMicknl] - [#170052]) ([overkiz docs]) - Fix tilt controls for TiltOnlyVenetianBlind in Overkiz ([@iMicknl] - [#170055]) ([overkiz docs]) - Fix cover controls for UpDownBioclimaticPergola in Overkiz ([@iMicknl] - [#170058]) ([overkiz docs]) - Bump pyOverkiz to 1.20.3 ([@iMicknl] - [#170060]) ([overkiz docs]) (dependency) - Bump deebot-client to 18.3.0 ([@edenhaus] - [#170066]) ([ecovacs docs]) (dependency) - Set `is_closed` state to `None` when a cover state returns "unknown" in Overkiz ([@iMicknl] - [#170081]) ([overkiz docs]) - Fix sensors getting wrong unit from MeasuredValueType attribute in Overkiz ([@iMicknl] - [#170088]) ([overkiz docs]) - Fix Z-Wave discovery crash with unknown node firmware version ([@TheJulianJES] - [#170090]) ([zwave\_js docs][zwave_js docs]) - Bump ZHA to 1.3.1 ([@TheJulianJES] - [#170095]) ([zha docs]) (dependency) - Bump python-bsblan to 5.2.1 ([@liudger] - [#170100]) ([bsblan docs]) (dependency) - Bump blebox\_uniapi to v2.5.3 ([@bkobus-bbx] - [#170115]) ([blebox docs]) (dependency) - Fix is\_closed state for DynamicGate covers in Overkiz ([@iMicknl] - [#170130]) ([overkiz docs]) - Fix tilt support for UpDownVenetianBlind (rts:VenetianBlindRTSComponent) in Overkiz ([@iMicknl] - [#170047]) ([overkiz docs]) [#166799]: home-assistant/core#166799 [#168456]: home-assistant/core#168456 [#169484]: home-assistant/core#169484 [#169739]: home-assistant/core#169739 [#169776]: home-assistant/core#169776 [#169911]: home-assistant/core#169911 [#169914]: home-assistant/core#169914 [#169928]: home-assistant/core#169928 [#169939]: home-assistant/core#169939 [#169947]: home-assistant/core#169947 [#169981]: home-assistant/core#169981 [#169991]: home-assistant/core#169991 [#170030]: home-assistant/core#170030 [#170038]: home-assistant/core#170038 [#170047]: home-assistant/core#170047 [#170052]: home-assistant/core#170052 [#170055]: home-assistant/core#170055 [#170058]: home-assistant/core#170058 [#170060]: home-assistant/core#170060 [#170066]: home-assistant/core#170066 [#170081]: home-assistant/core#170081 [#170088]: home-assistant/core#170088 [#170090]: home-assistant/core#170090 [#170095]: home-assistant/core#170095 [#170100]: home-assistant/core#170100 [#170115]: home-assistant/core#170115 [#170130]: home-assistant/core#170130 [@Danielhiversen]: https://github.com/Danielhiversen [@Kane610]: https://github.com/Kane610 [@TheJulianJES]: https://github.com/TheJulianJES [@agners]: https://github.com/agners [@bkobus-bbx]: https://github.com/bkobus-bbx [@edenhaus]: https://github.com/edenhaus [@elupus]: https://github.com/elupus [@emontnemery]: https://github.com/emontnemery [@frenck]: https://github.com/frenck [@gjohansson-ST]: https://github.com/gjohansson-ST [@iMicknl]: https://github.com/iMicknl [@jeeftor]: https://github.com/jeeftor [@liudger]: https://github.com/liudger [@mib1185]: https://github.com/mib1185 [@puddly]: https://github.com/puddly [@robwasripped]: https://github.com/robwasripped [@ronaldvdmeer]: https://github.com/ronaldvdmeer [@th3spis]: https://github.com/th3spis [acer_projector docs]: https://www.home-assistant.io/integrations/acer_projector/ [axis docs]: https://www.home-assistant.io/integrations/axis/ [blebox docs]: https://www.home-assistant.io/integrations/blebox/ [bsblan docs]: https://www.home-assistant.io/integrations/bsblan/ [duco docs]: https://www.home-assistant.io/integrations/duco/ [ecovacs docs]: https://www.home-assistant.io/integrations/ecovacs/ [fritz docs]: https://www.home-assistant.io/integrations/fritz/ [gardena_bluetooth docs]: https://www.home-assistant.io/integrations/gardena_bluetooth/ [hassio docs]: https://www.home-assistant.io/integrations/hassio/ [holiday docs]: https://www.home-assistant.io/integrations/holiday/ [husqvarna_automower_ble docs]: https://www.home-assistant.io/integrations/husqvarna_automower_ble/ [intellifire docs]: https://www.home-assistant.io/integrations/intellifire/ [overkiz docs]: https://www.home-assistant.io/integrations/overkiz/ [serial docs]: https://www.home-assistant.io/integrations/serial/ [tibber docs]: https://www.home-assistant.io/integrations/tibber/ [todo docs]: https://www.home-assistant.io/integrations/todo/ [usb docs]: https://www.home-assistant.io/integrations/usb/ [wiz docs]: https://www.home-assistant.io/integrations/wiz/ [workday docs]: https://www.home-assistant.io/integrations/workday/ [zha docs]: https://www.home-assistant.io/integrations/zha/ [zwave_js docs]: https://www.home-assistant.io/integrations/zwave_js/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/411

iMicknl added 3 commits May 7, 2026 14:14

Improve test: use existing fixture and parametrize command checks

c49bcd7

Move the TiltOnlyVenetianBlind device into the existing RTS fixture and replace the monolithic test with a parametrized test focused on verifying the correct command and parameters are sent for each service.

Add support for specific tilt commands in TiltOnlyVenetianBlind cover

3e9c849

Copilot AI review requested due to automatic review settings May 7, 2026 20:27

home-assistant Bot added bugfix cla-signed has-tests integration: overkiz small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage by-code-owner Quality Scale: No score labels May 7, 2026

Copilot started reviewing on behalf of iMicknl May 7, 2026 20:28 View session

iMicknl changed the title ~~Fix/overkiz tilt only venetian blind 169999~~ Fix tilt controls for TiltOnlyVenetianBlind in Overkiz May 7, 2026

iMicknl added this to the 2026.5.1 milestone May 7, 2026

Copilot AI reviewed May 7, 2026

View reviewed changes

iMicknl marked this pull request as draft May 7, 2026 21:00

iMicknl added 2 commits May 7, 2026 23:21

Fix prettify

4be434a

Copilot AI review requested due to automatic review settings May 7, 2026 21:27

iMicknl marked this pull request as ready for review May 7, 2026 21:27

Copilot started reviewing on behalf of iMicknl May 7, 2026 21:28 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread homeassistant/components/overkiz/cover.py

Merge remote-tracking branch 'upstream/dev' into fix/overkiz-tilt-onl…

5d8c22c

…y-venetian-blind-169999

Merge remote-tracking branch 'upstream/dev' into fix/overkiz-tilt-onl…

77f0e1e

…y-venetian-blind-169999

Copilot AI review requested due to automatic review settings May 7, 2026 21:52

Copilot started reviewing on behalf of iMicknl May 7, 2026 21:53 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread tests/components/overkiz/test_cover.py Outdated

Docstring fix

c1400bd

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 8, 2026 07:09

Copilot started reviewing on behalf of iMicknl May 8, 2026 07:10 View session

iMicknl added 2 commits May 8, 2026 09:12

Merge remote-tracking branch 'origin/dev' into fix/overkiz-tilt-only-…

7c62281

…venetian-blind-169999 # Conflicts: # tests/components/overkiz/test_cover.py

Merge branch 'fix/overkiz-tilt-only-venetian-blind-169999' of github.…

7b6a354

…com:iMicknl/home-assistant-core into fix/overkiz-tilt-only-venetian-blind-169999

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread homeassistant/components/overkiz/executor.py

Comment thread homeassistant/components/overkiz/cover.py

Comment thread tests/components/overkiz/fixtures/setup/cloud_somfy_connexoon_rts_asia.json

Comment thread tests/components/overkiz/test_cover.py

Format test case for DYNAMIC_GARAGE_DOOR_OGP in cover entities snapsh…

1c54c23

…ot test

joostlek approved these changes May 8, 2026

View reviewed changes

joostlek merged commit bb6087c into home-assistant:dev May 8, 2026
33 checks passed

frenck added the cherry-picked label May 8, 2026

frenck pushed a commit that referenced this pull request May 8, 2026

Fix tilt controls for TiltOnlyVenetianBlind in Overkiz (#170055)

7b749b9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

frenck mentioned this pull request May 8, 2026

2026.5.1 #170146

Merged

pgs-bot Bot mentioned this pull request May 9, 2026

Update Home Assistant to v2026.5.1 progamesigner/manifests#915

Merged

github-actions Bot locked and limited conversation to collaborators May 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix tilt controls for TiltOnlyVenetianBlind in Overkiz#170055

Fix tilt controls for TiltOnlyVenetianBlind in Overkiz#170055
joostlek merged 11 commits into
home-assistant:devfrom
iMicknl:fix/overkiz-tilt-only-venetian-blind-169999

iMicknl commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

iMicknl commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

iMicknl commented May 7, 2026

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

iMicknl commented May 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants