Proper handling of malformed data during FRITZ!Box Tools setup by mib1185 · Pull Request #170030 · home-assistant/core

mib1185 · 2026-05-07T17:16:13Z

Proposed change

As observed in #151241 some malformed data in the system event log of the FRITZ!Box itself can cause a parsing error, which causes the integration setup to fail. We now catch this parsing error during setup and provide the user with a proper error message. As we rely on the default retry behavior of the config entry setup, the error state will automatically be resolved after the user has delete the malformed system event logs.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes AVM FRITZ!Box Tools broken after Firmware Update 8.20 on FritzBox 6591 #151241
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-05-07T17:16:24Z

Hey there @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign fritz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

This PR improves robustness of the AVM FRITZ!Box Tools integration by handling malformed XML returned during get_device_info() at setup time, surfacing a translated, user-actionable error instead of failing setup with an unhandled parsing exception.

Changes:

Catch xml.etree.ElementTree.ParseError during coordinator setup and raise ConfigEntryNotReady with a translated reason key.
Add an exceptions translation message (error_parse_device_info) instructing the user how to remediate the issue.
Add a regression test ensuring setup enters SETUP_RETRY and exposes the correct translation key when a parse error occurs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`homeassistant/components/fritz/coordinator.py`	Wraps device-info fetch in a `ParseError` handler and maps it to a translated `ConfigEntryNotReady` retry reason.
`homeassistant/components/fritz/strings.json`	Adds a new exception translation string for the parse-error setup failure.
`tests/components/fritz/test_init.py`	Adds coverage verifying setup retry + correct translation key when device-info parsing fails.

zweckj · 2026-05-07T17:19:15Z

      "message": "Failed to perform action \"{service}\". Config entry for target not found"
    },
+    "error_parse_device_info": {
+      "message": "Error parsing device info. Please check the system event log of your FRITZ!Box for malformed data and clear the event list."


would a user recognize malformed data?

the malformed data would look like:

26.08.25 01:28:49 IPv6-Präfix konnte nicht bezogen werden, Fehlergrund: 0 (��m1�m��m�o�m�a��a��Y�m��l�)

but even the user wouldn't recognize it in the first place, the instruction says "...and clear the event list" which will finally resolve the issue

chemelli74 · 2026-05-07T19:10:23Z

I would go as far as creating a repair issue for such scenario.

…2026.5.0 → 2026.5.1) (#411) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.5.0` → `2026.5.1` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary> ### [`v2026.5.1`](https://github.com/home-assistant/core/releases/tag/2026.5.1) [Compare Source](home-assistant/core@2026.5.0...2026.5.1) - Added wfsens as a occupancy source in wiz ([@th3spis] - [#166799]) ([wiz docs]) - Fix WiZ Light config flow timeout by properly closing UDP connections ([@robwasripped] - [#168456]) ([wiz docs]) - Fix IntelliFire setup recovery ([@jeeftor] - [#169739]) ([intellifire docs]) - Fix hassio auth IndexError on Supervisor Unix socket requests ([@agners] - [#169911]) ([hassio docs]) - Update gardena ble to 2.8.1 ([@elupus] - [#169914]) ([gardena\_bluetooth docs][gardena_bluetooth docs]) ([husqvarna\_automower\_ble docs][husqvarna_automower_ble docs]) (dependency) - Bump serialx to 1.7.1 ([@puddly] - [#169928]) ([serial docs]) ([acer\_projector docs][acer_projector docs]) ([usb docs]) (dependency) - Bump holidays to 0.96 ([@gjohansson-ST] - [#169939]) ([workday docs]) ([holiday docs]) (dependency) - Add support for options to todo triggers ([@emontnemery] - [#169947]) ([todo docs]) - Bump pyTibber to 0.37.5 ([@Danielhiversen] - [#169981]) ([tibber docs]) (dependency) - Bump python-duco-client to 0.4.0 ([@ronaldvdmeer] - [#169776]) ([duco docs]) (dependency) - Bump python-duco-client to 0.4.1 ([@ronaldvdmeer] - [#169991]) ([duco docs]) (dependency) - Proper handling of malformed data during FRITZ!Box Tools setup ([@mib1185] - [#170030]) ([fritz docs]) - Fix websocket certificate verification Bump axis to v70 ([@Kane610] - [#170038]) ([axis docs]) (dependency) - Fix `is_closed` state for DynamicGarageDoor in Overkiz ([@iMicknl] - [#170052]) ([overkiz docs]) - Fix tilt controls for TiltOnlyVenetianBlind in Overkiz ([@iMicknl] - [#170055]) ([overkiz docs]) - Fix cover controls for UpDownBioclimaticPergola in Overkiz ([@iMicknl] - [#170058]) ([overkiz docs]) - Bump pyOverkiz to 1.20.3 ([@iMicknl] - [#170060]) ([overkiz docs]) (dependency) - Bump deebot-client to 18.3.0 ([@edenhaus] - [#170066]) ([ecovacs docs]) (dependency) - Set `is_closed` state to `None` when a cover state returns "unknown" in Overkiz ([@iMicknl] - [#170081]) ([overkiz docs]) - Fix sensors getting wrong unit from MeasuredValueType attribute in Overkiz ([@iMicknl] - [#170088]) ([overkiz docs]) - Fix Z-Wave discovery crash with unknown node firmware version ([@TheJulianJES] - [#170090]) ([zwave\_js docs][zwave_js docs]) - Bump ZHA to 1.3.1 ([@TheJulianJES] - [#170095]) ([zha docs]) (dependency) - Bump python-bsblan to 5.2.1 ([@liudger] - [#170100]) ([bsblan docs]) (dependency) - Bump blebox\_uniapi to v2.5.3 ([@bkobus-bbx] - [#170115]) ([blebox docs]) (dependency) - Fix is\_closed state for DynamicGate covers in Overkiz ([@iMicknl] - [#170130]) ([overkiz docs]) - Fix tilt support for UpDownVenetianBlind (rts:VenetianBlindRTSComponent) in Overkiz ([@iMicknl] - [#170047]) ([overkiz docs]) [#166799]: home-assistant/core#166799 [#168456]: home-assistant/core#168456 [#169484]: home-assistant/core#169484 [#169739]: home-assistant/core#169739 [#169776]: home-assistant/core#169776 [#169911]: home-assistant/core#169911 [#169914]: home-assistant/core#169914 [#169928]: home-assistant/core#169928 [#169939]: home-assistant/core#169939 [#169947]: home-assistant/core#169947 [#169981]: home-assistant/core#169981 [#169991]: home-assistant/core#169991 [#170030]: home-assistant/core#170030 [#170038]: home-assistant/core#170038 [#170047]: home-assistant/core#170047 [#170052]: home-assistant/core#170052 [#170055]: home-assistant/core#170055 [#170058]: home-assistant/core#170058 [#170060]: home-assistant/core#170060 [#170066]: home-assistant/core#170066 [#170081]: home-assistant/core#170081 [#170088]: home-assistant/core#170088 [#170090]: home-assistant/core#170090 [#170095]: home-assistant/core#170095 [#170100]: home-assistant/core#170100 [#170115]: home-assistant/core#170115 [#170130]: home-assistant/core#170130 [@Danielhiversen]: https://github.com/Danielhiversen [@Kane610]: https://github.com/Kane610 [@TheJulianJES]: https://github.com/TheJulianJES [@agners]: https://github.com/agners [@bkobus-bbx]: https://github.com/bkobus-bbx [@edenhaus]: https://github.com/edenhaus [@elupus]: https://github.com/elupus [@emontnemery]: https://github.com/emontnemery [@frenck]: https://github.com/frenck [@gjohansson-ST]: https://github.com/gjohansson-ST [@iMicknl]: https://github.com/iMicknl [@jeeftor]: https://github.com/jeeftor [@liudger]: https://github.com/liudger [@mib1185]: https://github.com/mib1185 [@puddly]: https://github.com/puddly [@robwasripped]: https://github.com/robwasripped [@ronaldvdmeer]: https://github.com/ronaldvdmeer [@th3spis]: https://github.com/th3spis [acer_projector docs]: https://www.home-assistant.io/integrations/acer_projector/ [axis docs]: https://www.home-assistant.io/integrations/axis/ [blebox docs]: https://www.home-assistant.io/integrations/blebox/ [bsblan docs]: https://www.home-assistant.io/integrations/bsblan/ [duco docs]: https://www.home-assistant.io/integrations/duco/ [ecovacs docs]: https://www.home-assistant.io/integrations/ecovacs/ [fritz docs]: https://www.home-assistant.io/integrations/fritz/ [gardena_bluetooth docs]: https://www.home-assistant.io/integrations/gardena_bluetooth/ [hassio docs]: https://www.home-assistant.io/integrations/hassio/ [holiday docs]: https://www.home-assistant.io/integrations/holiday/ [husqvarna_automower_ble docs]: https://www.home-assistant.io/integrations/husqvarna_automower_ble/ [intellifire docs]: https://www.home-assistant.io/integrations/intellifire/ [overkiz docs]: https://www.home-assistant.io/integrations/overkiz/ [serial docs]: https://www.home-assistant.io/integrations/serial/ [tibber docs]: https://www.home-assistant.io/integrations/tibber/ [todo docs]: https://www.home-assistant.io/integrations/todo/ [usb docs]: https://www.home-assistant.io/integrations/usb/ [wiz docs]: https://www.home-assistant.io/integrations/wiz/ [workday docs]: https://www.home-assistant.io/integrations/workday/ [zha docs]: https://www.home-assistant.io/integrations/zha/ [zwave_js docs]: https://www.home-assistant.io/integrations/zwave_js/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/411

handle malformed data during integration setup

ca2b89f

mib1185 added this to the 2026.5.1 milestone May 7, 2026

Copilot AI review requested due to automatic review settings May 7, 2026 17:16

mib1185 requested a review from chemelli74 as a code owner May 7, 2026 17:16

home-assistant Bot added bugfix cla-signed has-tests integration: fritz small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage labels May 7, 2026

home-assistant Bot assigned chemelli74 May 7, 2026

home-assistant Bot added by-code-owner Quality Scale: gold labels May 7, 2026

Copilot started reviewing on behalf of mib1185 May 7, 2026 17:17 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

zweckj reviewed May 7, 2026

View reviewed changes

zweckj approved these changes May 7, 2026

View reviewed changes

zweckj merged commit db25f19 into dev May 7, 2026
37 checks passed

zweckj deleted the fritz/fetch-malformed-data-during-integration-setup branch May 7, 2026 17:59

mib1185 mentioned this pull request May 8, 2026

FritzBox Parsing Issue crashes FritzConnection kbr/fritzconnection#247

Closed

frenck added the cherry-picked label May 8, 2026

frenck pushed a commit that referenced this pull request May 8, 2026

Proper handling of malformed data during FRITZ!Box Tools setup (#170030)

44b1fea

frenck mentioned this pull request May 8, 2026

2026.5.1 #170146

Merged

pgs-bot Bot mentioned this pull request May 9, 2026

Update Home Assistant to v2026.5.1 progamesigner/manifests#915

Merged

github-actions Bot locked and limited conversation to collaborators May 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Proper handling of malformed data during FRITZ!Box Tools setup#170030

Proper handling of malformed data during FRITZ!Box Tools setup#170030
zweckj merged 1 commit into
devfrom
fritz/fetch-malformed-data-during-integration-setup

mib1185 commented May 7, 2026 •

edited

Loading

Uh oh!

home-assistant Bot commented May 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

zweckj May 7, 2026

Uh oh!

mib1185 May 7, 2026

Uh oh!

Uh oh!

chemelli74 commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

mib1185 commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented May 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

zweckj May 7, 2026

Choose a reason for hiding this comment

Uh oh!

mib1185 May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chemelli74 commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mib1185 commented May 7, 2026 •

edited

Loading